add dotAll regexp flag#133
Merged
thomashoneyman merged 1 commit intopurescript:masterfrom Dec 23, 2020
Merged
Conversation
57 tasks
kl0tl
approved these changes
Dec 21, 2020
Member
kl0tl
left a comment
kl0tl
left a comment
There was a problem hiding this comment.
Support for this flag is almost on par with the unicode and sticky flags that we already have (see https://kangax.github.io/compat-table/es2016plus/#test-s_(dotAll)_flag_for_regular_expressions and https://kangax.github.io/compat-table/es6/#test-RegExp_y_and_u_flags), so albeit this is an ES2018 feature I think we can merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag is useful especially when it's used with replace function. Let's say we have a big string that contains html and we want to extract the title from it. If we have dotAll regexp flag, we can write the code like this:
replace (unsafeRegex "^.*<title>([^<]+)</title>.*$" dotAll) "$1" bigStringIt's quite quick and simple. With this, we can remove unneeded parts over multiple lines. This flag is supported by ES2018 and currently, node.js and browsers other than Internet Explorer and Firefox for Android cover that.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/dotAll