Fix Three Spec and Doc Drift Findings from HomeAutomation-Config Audit - #994
Merged
Conversation
Reword the .editorconfig comment above the .NET-only block so it states the whole-file carry model instead of contradicting it (a non-.NET repo keeps the section unused rather than dropping it), matching CODESTYLE.md 'General'. Declare 'When in Doubt' in spec/files.json's sections array for .github/copilot-instructions.md, since the hub's own canonical file carries that heading and its absence from the manifest flagged it as phantom drift on every repo that carries the file verbatim. Add accepted gap entries in spec/divergences.json for .github/actionlint.yaml and .github/actions/validate/action.yml, both HomeAutomation-Config's own content at paths the hub also hosts (a path collision, not a carry), matching the existing accepted entries for LICENSE, TODO.md, .husky/pre-commit, and scripts/README.md.
PR Summary by QodoCorrect Audit Spec and Documentation Drift
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates repository governance metadata. It clarifies ChangesGovernance baseline
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR makes localized specification and documentation corrections, with reported validation and tests passing; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code Review by Qodo
1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
The copilot-instructions-keeper skill still described three named
sections in spec/files.json for .github/copilot-instructions.md, both
in its overview and its update checklist, after this PR added a
fourth ('When in Doubt'). Regenerated both distribution trees with
scripts/build_dist.py.
This was referenced Aug 25, 2026
Merged
ptr727
added a commit
that referenced
this pull request
Aug 25, 2026
Follow-up to #994: \`reports/divergences.md\` is generated from \`spec/divergences.json\` by \`spec/fidelity_honesty.py --report\` and had not been regenerated after #994 added \`accepted\` entries for \`.github/actionlint.yaml\` and \`.github/actions/validate/action.yml\`, leaving the checked-in report stale. Caught by CodeRabbit on the develop -> main promotion PR (#996), which cannot carry the fix directly since its diff is develop against main. Landing it here so #996 picks it up on develop's next head. Ran \`python3 spec/fidelity_honesty.py --report\` (read-only against GitHub, writes only the local report file) and committed the regenerated \`reports/divergences.md\`, which now documents both new dispositions. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Regenerated the divergence report with refreshed fleet findings and dispositions. * Updated the list of items requiring re-vendor review. * Revised accepted and untriaged findings for improved accuracy and clarity. * Streamlined the list of stale-copy entries to reflect the current set of identified items. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
ptr727
added a commit
that referenced
this pull request
Aug 25, 2026
Promotes #994 (issues #988, #989, #990) to `main`. ## What - `.editorconfig` rewords the comment above the `.NET`-only block so it states the whole-file carry model instead of contradicting CODESTYLE.md's "General" section (#988). - `spec/files.json` declares `"When in Doubt"` in the `sections` array for `.github/copilot-instructions.md`, so the hub's own canonical fourth heading is no longer flagged as undeclared drift (#989). - `spec/divergences.json` adds two `accepted` gap entries, for `.github/actionlint.yaml` and `.github/actions/validate/action.yml`, matching the existing `accepted` pattern for path collisions (#990). - `copilot-instructions-keeper`'s SKILL.md (source plus both regenerated distribution trees) is updated to enumerate all four declared sections instead of three, a follow-up fix from PR #994's own review loop. ## Review PR #994 review loop: qodo-code-review raised one real finding (the keeper skill's stale three-section enumeration), fixed and resolved in b626b25. Copilot's own review account is in the fleet's known repo-wide quota-exhausted state (confirmed live on every request this round), so this proceeded on qodo's coverage per standing precedent. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated Copilot instruction guidance to include the required “When in Doubt” section. * Updated synchronization instructions and baseline requirements accordingly. * Added guidance for safely retiring outdated local paths during resynchronization. * Clarified .NET line-ending governance across derived repositories. * Refreshed divergence reporting and the current stale-copy inventory. * **Chores** * Recorded approved repository-specific configuration differences. * Refreshed internal skill metadata and synchronization records. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #988, #989, #990.
Three small, independent, verified findings from today's HomeAutomation-Config resync audit, bundled together since they are all mechanical spec/doc-accuracy corrections found by the same audit run.
Changes
.editorconfig(The hub's own .editorconfig comment contradicts CODESTYLE.md's whole-file carry model #988): reworded the comment above the.NET-only block so it states the whole-file carry model instead of contradicting it. It previously said a non-.NET repo "may drop from here down," which disagreed withCODESTYLE.md"General": a repo keeps the whole file, including inert language-specific blocks, rather than trimming it.spec/files.json(spec/files.json doesn't declare copilot-instructions.md's 'When in Doubt' section, so every carrying repo gets a phantom drift finding #989): added"When in Doubt"to the declaredsectionsarray for.github/copilot-instructions.md. The hub's own canonical file carries that heading (right after the "Disproved Claims" ledger), but it wasn't declared, sospec/audit.py's undeclared-section advisory flagged it as drift on every repo carrying the file verbatim.spec/divergences.json(spec/divergences.json 'gaps' has no disposition for .github/actionlint.yaml or .github/actions/validate/action.yml, so audit.py flags them as untriaged every run #990): added twoacceptedgap entries, for.github/actionlint.yamland.github/actions/validate/action.yml. Both are HomeAutomation-Config's own content at paths the hub also hosts (a path collision, not a carry), the same pattern as the existingacceptedentries forLICENSE,TODO.md,.husky/pre-commit, andscripts/README.mdin the samegapsarray.Verification
python3 -c "import json; json.load(...)"on both edited spec filespython3 spec/validate.py(clean)python3 scripts/prose_lint.py --diff origin/develop(clean)python3 scripts/repo_gate.py(clean)python3 spec/audit.py --selftest(pass)python3 -m unittest discover -s scripts/tests(846 tests, pass)Note: "Fixes #988, #989, #990" won't auto-close the issues on this merge since it targets
develop; they close on the nextdevelop -> mainpromotion, per fleet convention.Summary by CodeRabbit
Documentation
Configuration