Keep Missing-Job Fixture Internally Consistent - #851
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the spec/audit.py --selftest missing-job fixture so it represents only the intended contract failure (a missing validate job) without also modeling inconsistent needs wiring.
Changes:
- Update the missing-
validatefixture sopublishdeclaresvalidateinneedswhile still omitting thevalidatejob definition.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Merged
ptr727
added a commit
that referenced
this pull request
Aug 19, 2026
## Summary - Promote fail-closed release validation and audit path discovery. - Promote explicit Bash labels for executable audit commands. - Promote the canonical PyPI artifact-name regression guard. - Promote the executable Python entry point for the release-guard test. - Promote the internally consistent missing-job audit fixture. ## Source - #844 (`a08713a`) - #847 (`af2c8ff`) - #848 (`1cd5b84`) - #849 (`87c3960`) - #850 (`9b6c01f`) - #851 (`bb4d603`) ## Validation - 730 Python tests - audit self-tests and spec validation - ruff, mypy, and coverage - actionlint, markdownlint, EditorConfig, CSpell, ShellCheck, and PSScriptAnalyzer - Copilot full-diff review on each feature pull request Closes #842 Closes #843 Closes #845
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validatein the missing-job fixture'sneedslistvalidate:job definition absent so the fixture isolates that contract failureRoot Cause
The fixture referenced
needs.validate.resultwithout declaringvalidateas a dependency. It therefore modeled an additional workflow defect beyond the missing job it was designed to test.Impact
The audit self-test exercises one deliberate defect and remains representative of a real caller shape.
Verification
python3 spec/audit.py --selftestpython3 -m unittest discover -s scripts/tests(730 tests)uvx ruff@latest check spec/audit.pyuvx ruff@latest format --check spec/audit.pygit diff --checkAddresses a suppressed Copilot finding on #846.