Re-sort the two definition blocks #588 pushed out of order - #590
Merged
Conversation
#586 named the collation for reference-definition sort order as the text inside the brackets, and #588 then inserted into two blocks without applying it. `CODESTYLE.md` appended the two `vscode-tasks` links after `ruff-link`, leaving `uv-link` stranded below them, and `docs/repo-config-carry.md` put `governance-hub-hosted-tooling` at the head of a group `#586` had itself just sorted. Both are the trap that rule records. A plain `sort -c` over either block compares the whole line and reports it ordered, so the defect survives a mechanical check and reaches review, which is where Copilot caught both. A sweep over every definition group in the tree, keyed on the bare label, reports these two and no others, and zero after this change. Refs #583 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores the repository’s established reference-definition sort collation (by the bare label inside []) in two Markdown definition blocks that were previously reordered inconsistently, without changing any reference names or link targets.
Changes:
- Reorders the
<!-- Repo -->reference-definition group indocs/repo-config-carry.mdsogovernance-hub-hosted-toolingsorts after the othergovernance-*entries. - Reorders the
<!-- External -->reference-definition group inCODESTYLE.mdsouv-linksorts betweenruff-linkand thevscode-tasks-*links.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/repo-config-carry.md | Fixes reference-definition ordering in the <!-- Repo --> group to match the documented collation. |
| CODESTYLE.md | Fixes reference-definition ordering in the <!-- External --> group so uv-link is correctly positioned. |
ptr727
added a commit
that referenced
this pull request
Aug 6, 2026
…, and the operational pull-request trigger (#589) Promotes the five commits develop carried since #582: #584 (a Copilot refusal is not coverage), #586 (the reference-definition collation), #587 (CI on a pull request into an operational develop), #588 (hub-hosted tooling, de-vendoring configure.sh), and #590 (the two definition blocks #588 pushed out of order). Merge commit, no squash, develop not deleted. git merge-tree reported no conflict and wrote a tree byte-identical to origin/develop. GOVERNANCE.md is verbatim-carried and three of these commits change it, so a fleet re-vendor is owed, including an entirely new carried section. #588 also turns every downstream repo-config/configure.sh copy into a deletion rather than a convergence, and #587 leaves a one-line trigger change owed by four operational repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#586 named the collation for reference-definition sort order as the text inside the brackets, and #588 then inserted into two blocks without applying it. Found by Copilot on the promotion pull request #589, which is blocked on both threads.
The two blocks
CODESTYLE.mdappended the twovscode-taskslinks afterruff-linkwhen it repointed them into hub-onlycatalog/, which strandeduv-linkbelow them.uv-linkbelongs betweenruff-linkandvscode-tasks-link.docs/repo-config-carry.mdputgovernance-hub-hosted-toolingat the head of a<!-- Repo -->group Name the collation for the reference-definition sort order #586 had itself just sorted, abovegovernance-documentation-styleandgovernance-git-and-commit-rules.Both are pure reorderings. No link target, anchor, or reference name changes, so no rendered output changes.
Why a mechanical check did not catch it
This is exactly the trap #586 recorded when it named the key. A plain
sort -cover either block compares the whole line rather than the bracketed label, and both blocks pass that reading, so a "sorted" block reaches review looking consistent. Nothing inrepo_gate.pyorprose_lint.pyasserts the order today, which is why the reviewer is the only surface that flagged it.Verification
A sweep over every reference-definition group in every markdown file in the tree, keyed on the bare label, reports these two groups and no others before the change, and zero after it.
scripts/prose_lint.py --diff origin/developandscripts/repo_gate.pyare both clean.Refs #583