Skip to content

Record what a run observed rather than what it predicted - #556

Merged
ptr727 merged 1 commit into
developfrom
report-observed-not-predicted
Aug 3, 2026
Merged

Record what a run observed rather than what it predicted#556
ptr727 merged 1 commit into
developfrom
report-observed-not-predicted

Conversation

@ptr727

@ptr727 ptr727 commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Both findings from the review on promotion #555. A promotion's head is develop, so the fix lands here and #555 picks it up.

The report predicted, and the prediction was wrong

reports/blog/audit.md closed a paragraph with:

...and the same four will appear against every fleet repo the moment that change promotes:

Two things wrong with that, and the second is why it matters.

A report records what a run observed. A prediction cannot be verified by re-running the audit, which is the one check the run-stamp discipline offers a reader.

And it turned out to be false. The change promoted. The four findings were then traced to spec/audit.py asserting a bypass_actors list that configure.sh had deliberately stopped managing, and #551 removed that assertion. So they do not appear against every fleet repo. Verified: spec/audit.py Blog reports 0 defect/letter/error on this branch.

A prediction goes stale the moment reality diverges and nothing re-checks it. That is the same failure the registry's driftNote rules already name, arriving in a report instead — and it is the second instance today of a document asserting a future that stopped being true.

The sentence now ends at the reason those findings were not counted, and hands off to the enumeration that follows it.

The comment attached its clause to the wrong noun

-# Phrases in a registry driftNote that assert work is still outstanding.
+# Phrases that assert work is still outstanding, matched against a registry driftNote.

The subject is the plural phrases, so assert was correct, but driftNote that assert sits adjacent and reads as a disagreement. Reordered so the clause sits with what it describes. This is the second pass over these two lines today, the first having added a missing verb.

Verification

Diff-scoped prose_lint clean, editorconfig clean, CRLF preserved on the report, spec/audit.py parses, and the audit still reports Blog at zero findings.

Two findings from the review on the promotion, and the second is the one that
matters.

The Blog audit report closed a paragraph with a prediction, that the same four
findings "will appear against every fleet repo the moment that change
promotes". A report records what a run observed. It also turned out to be
wrong: the change promoted, the findings were traced to spec/audit.py asserting
a bypass list the config had deliberately stopped managing, and #551 removed
that assertion, so the four do not appear. A prediction in a report is stale the
moment reality diverges and nothing re-checks it, which is the same failure the
driftNote rules already name in the registry.

The sentence now ends at the reason the findings were not counted and hands off
to the enumeration that follows.

The PENDING_MARKERS comment put its relative clause next to the wrong noun, so
"a registry driftNote that assert" read as a disagreement even though the
subject is the plural phrases. Reordered so the clause sits with what it
describes.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings August 3, 2026 23:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates audit/report wording to record what an audit run observed rather than making forward-looking predictions, keeping reports verifiable by re-running the same audit.

Changes:

  • Rewords reports/blog/audit.md to remove a future-tense prediction and instead summarize the re-run’s observed results.
  • Rephrases a comment in spec/audit.py so the relative clause clearly modifies “phrases” (not “driftNote”).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
spec/audit.py Clarifies wording in the PENDING_MARKERS comment without changing logic.
reports/blog/audit.md Removes an unverifiable prediction and frames the paragraph as an observation from the re-run.

@ptr727
ptr727 merged commit 2951273 into develop Aug 3, 2026
7 checks passed
@ptr727
ptr727 deleted the report-observed-not-predicted branch August 3, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants