Clarify minProfile default and the coverage enforcement - #442
Merged
Conversation
minProfile is optional: a check without one applies at every profile, and only build checks set it. State that, and describe the enforcement accurately - the audit gates the coverage requirement on the declared profile, rather than reading minProfile - so the doc matches the current spec and audit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the language type model documentation to clarify how minProfile behaves by default and how coverage requirements are actually enforced by the audit, aligning the doc with the current schema and audit behavior.
Changes:
- Clarify that
minProfileis optional and that omitting it means the check applies at all profiles. - Clarify that the audit gates the Codecov coverage requirement based on the declared language profile (so lint-only languages do not trigger coverage requirements).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routed from Copilot on the promotion #441: the model doc said every check names its minProfile, but the field is optional (only build checks set it) and omitting it means the check applies at every profile. Clarify that default, and word the enforcement accurately - the audit gates the coverage requirement on the declared profile, not by reading minProfile (which is documentation), and only coverage is mechanically gated, not packaging.
spec/validate.pyOK.🤖 Generated with Claude Code