Word the truncated-tree branch fallback neutrally - #436
Merged
Conversation
When the three-tree filter cannot run (a tree is truncated or unavailable), the audit has only the compare's file count, which cannot tell direction or filter cherry-picked content-equivalent changes. Assert only what is known - the paths differ - and that a forward-sync or a reconciliation may be needed, rather than claiming develop is behind. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the degraded branch-drift fallback message in spec/audit.py to avoid asserting a specific drift direction when the three-tree classification cannot run (e.g., truncated or unavailable trees). It keeps the finding accurate by stating only what the compare API can truly confirm in that scenario: the branches differ on some set of paths, and follow-up action may be needed.
Changes:
- Reword the truncated/unavailable-tree DRIFT message to be direction-neutral.
- Clarify in the message that direction cannot be classified when the tree data is missing/truncated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The degraded branch-check fallback (three-tree filter cannot run - a tree is truncated or unavailable) has only the compare's file count, which cannot tell direction or filter cherry-picked content-equivalent changes. Reword it to assert only what is known - the paths differ, and a forward-sync or reconciliation may be needed - instead of claiming develop is behind. Routed from Copilot on promotion #434.
spec/audit.py --selftestPASS,spec/validate.pyOK.🤖 Generated with Claude Code