Word the behind branch finding accurately for deletions - #435
Merged
Conversation
The behind bucket also holds a path main deleted that develop still carries, where "develop lacks <path>" misreads - develop has that path, main removed it. Say "develop is behind on" instead, which is accurate whether main's change was an addition, a modification, or a deletion. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the wording of the behind branch-drift DRIFT finding in spec/audit.py so it remains accurate when main deletes a path that develop still has.
Changes:
- Reword the
behindbucket message from “develop lacks” to “develop is behind on” to correctly cover deletions as well as additions/modifications.
Keep "path change(s)" in the precise message (the payload is a list of paths), and reword the truncated-tree fallback from "develop lacks" to "develop is behind on" too, so both branch findings read consistently and neither misreads a main-side deletion. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reword the
behindbranch-drift DRIFT message from "develop lacks " to "develop is behind on". Routed from Copilot on the promotion #434: thebehindbucket also catches a path main deleted that develop still carries, where "develop lacks" misreads (develop has the path; main removed it). "develop is behind on" is accurate for additions, modifications, and deletions alike.spec/audit.py --selftestPASS,spec/validate.pyOK.🤖 Generated with Claude Code