Drop the repo-wide analyzer-severity relaxation from .editorconfig (#353) - #400
Merged
Merged
Conversation
) `dotnet_analyzer_diagnostic.severity = suggestion` in the root `.editorconfig` demoted every analyzer to a non-failing suggestion fleet-wide, defeating the `AnalysisLevel=latest-all` + `AnalysisMode=All` the template sets - and CODESTYLE.md's "Analyzer Diagnostics and Suppressions" explicitly forbids relaxing `dotnet_analyzer_diagnostic.severity`. The line even contradicted its own adjacent comment ("never a brownfield batch"). Remove it; the specific `IDE0055` entry (formatting, enforced elsewhere) stays, which the comment now accurately governs. The hub has no C# build, so this only corrects the canonical every C# repo carries. The maintainer's fleet probe on #353 measured the impact: it hides essentially one rule (`xUnit1051`), three repos are already clean, two are small fixes, and PhotoCleaner's larger set is sequenced separately - the downstream re-vendor is per-repo follow-up, not this change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the repo-wide .NET analyzer severity demotion from the root .editorconfig so analyzer diagnostics are no longer blanket-relaxed to “suggestion”, aligning the template with the analyzer suppression rules described in CODESTYLE.md.
Changes:
- Deleted
dotnet_analyzer_diagnostic.severity = suggestionfrom the[*.cs]section of.editorconfig. - Kept the targeted
dotnet_diagnostic.IDE0055.severity = noneentry and the surrounding suppression guidance comment intact.
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the hub side of #353. The root
.editorconfigcarrieddotnet_analyzer_diagnostic.severity = suggestion, which demotes every analyzer to a non-failing suggestion fleet-wide — defeating theAnalysisLevel=latest-all+AnalysisMode=Allthe template sets, and exactly what CODESTYLE.md "Analyzer Diagnostics and Suppressions" (CODESTYLE.md:243) forbids. The line also contradicted its own adjacent comment ("never a brownfield batch").Change
dotnet_diagnostic.IDE0055.severity = noneentry (formatting, enforced elsewhere) stays — it's a per-rule entry the surviving comment accurately governs..editorconfigevery C# repo carries. CRLF preserved; one-line diff.Downstream (per your #353 probe, not this PR)
Removing the line surfaces the hidden findings when each repo re-vendors — essentially just
xUnit1051. Per the probe: PlexCleaner / MediaTools / NxWitness are already clean (free), AudioCleaner (20) / LanguageTags (24) are small PRs, PhotoCleaner (362) is sequenced separately.Utilitieswas already fixed (ptr727/Utilities#418).🤖 Generated with Claude Code