Conversation
Read-only fleet analysis checking the manifest's declared fidelities against reality: intent units uniform fleet-wide (verbatim candidates), verbatim units with non-stale drift, and a manifest-gap pass (carried-but-untracked files). First run surfaced real findings incl. 3 untracked carried files. Reuses audit.py; fail-loud; git-ls-files sourced.
…#388) Config-only pyproject.toml (Scripts profile): ruff (py313/100/isort) + mypy gate + pyright standard editor - all clean. audit.py: gh()->Any, typed cache, is-not-None narrowing. Aligned CODESTYLE Scripts profile (pyright editor allowance; uvx@latest pinning per the Dependabot-trackable rule) and reconciled spec/project-types.json. Resolves the Pylance unhappiness at the root.
Promote the 3 branch-ruleset payloads to verbatim (0 divergent copies) and track .editorconfig-checker.json (intent, carried but was untracked). Acting on the fidelity-honesty tool's first run.
Curated disposition ledger (spec/divergences.json) + fidelity_honesty.py --report -> reports/divergences.md, joining live fleet reality against the ledger. Makes the fidelity-honesty findings durable and systematically tracked. validate.py gates the ledger.
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes develop to main, bringing over new fleet-governance tooling (fidelity-honesty analysis + divergence ledger/report) plus supporting manifest/schema hardening and documentation updates for workflow and Python tooling conventions.
Changes:
- Add
spec/fidelity_honesty.pyand a checked-in divergence ledger/report (spec/divergences.json->reports/divergences.md), with CI validation of the ledger inspec/validate.py. - Harden the manifest by tracking
.editorconfig-checker.jsonand promoting ruleset payloads toverbatimfidelity inspec/files.json. - Update workflow and Python tooling guidance in
WORKFLOW.md,CODESTYLE.md, andspec/project-types.json, plus add a scripts-profilepyproject.toml.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| WORKFLOW.md | Prose-only edits clarifying workflow contract language (no behavioral YAML changes). |
| spec/validate.py | Adds validation for spec/divergences.json structure/content so ledger errors fail fast. |
| spec/project-types.json | Updates the scripts-profile uvx policy assertions to reflect “run latest” guidance. |
| spec/files.json | Tracks .editorconfig-checker.json; promotes ruleset payload entries to verbatim. |
| spec/fidelity_honesty.py | Introduces the fidelity-honesty analysis tool and report generator. |
| spec/divergences.schema.json | Adds JSON schema for the divergence ledger. |
| spec/divergences.json | Adds the curated divergence disposition ledger (inputs to the report). |
| spec/audit.py | Type annotations and small guard tweaks to support stricter typing and avoid None-path execution. |
| reports/divergences.md | Adds the generated burn-down report produced by the new tool. |
| pyproject.toml | Adds config-only ruff/mypy/pyright settings for the repo’s scripts-profile Python. |
| CODESTYLE.md | Updates the scripts-profile Python guidance to match the “uvx @latest” policy and pyright editor config. |
| .gitattributes | Pins LF for the new shebang-executed spec/fidelity_honesty.py. |
| .editorconfig | Pins LF for spec/fidelity_honesty.py alongside the other shebang-executed scripts. |
In --report mode, an unresolvable reference adopter (a typo) wrote a report whose empty gap section read as a false clean. Validate it up front and exit non-zero. Addresses a Copilot finding on the #391 promotion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the develop line to main. Merge-commit promotion (not squash);
developis the head and is never deleted.Included (5 commits)
spec/fidelity_honesty.py): checks the manifest's declared fidelities against fleet reality (intent-uniform → verbatim candidates, verbatim-with-divergence → mislabel, manifest gaps).pyproject.toml: ruff + mypy gate + pyright editor; CODESTYLE "Two profiles";uvx <tool>@latestper the Dependabot-trackable pinning rule).verbatim(0 divergent copies), track.editorconfig-checker.json.spec/divergences.json(+ schema) curated dispositions,fidelity_honesty.py --report→reports/divergences.mdjoining live fleet reality against the ledger (UNTRIAGED / resolved / unavailable handling), validated byvalidate.py.Verification
spec/validate.pygreen;spec/audit.py --selftestpasses; the divergence report regenerates and is markdownlint-clean. Trial merge is conflict-free.🤖 Generated with Claude Code