Skip to content

Refactor merge conditions and enhance documentation - #39

Merged
ptr727 merged 1 commit into
developfrom
prcodegen
Apr 13, 2026
Merged

Refactor merge conditions and enhance documentation#39
ptr727 merged 1 commit into
developfrom
prcodegen

Conversation

@ptr727

@ptr727 ptr727 commented Apr 13, 2026

Copy link
Copy Markdown
Owner

Refactor the merge conditions for codegen pull requests to improve workflow reliability and update the README documentation for clarity on permissions and workflow behavior.

…ation

Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 13, 2026 04:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the GitHub Actions automation around codegen pull requests to make auto-merge triggering more reliable, and updates documentation to clarify required token permissions and event behavior.

Changes:

  • Update codegen PR creation to use GITHUB_TOKEN, then close/reopen using WORKFLOW_PAT to trigger downstream pull_request workflows.
  • Refine the auto-merge job condition to distinguish reopened events (PAT actor) from normal workflow activity (Actions bot actor).
  • Improve CodeGen HTTP resilience behavior/logging and explicitly request JSON responses from the quotes API.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Clarifies PAT permissions and explains why close/reopen is required to trigger downstream workflows.
CodeGen/HttpClientFactory.cs Refactors retry/circuit-breaker configuration, adds logging hooks, and tightens transient-failure detection.
CodeGen/ApiNinjas.cs Adds an explicit Accept: application/json header for the API request.
.github/workflows/run-codegen-pull-request-task.yml Switches PR creation to GITHUB_TOKEN and adds a PAT-driven close/reopen step to trigger pull_request workflows.
.github/workflows/merge-bot-pull-request.yml Updates merge gating logic to align with the new close/reopen triggering strategy.

@ptr727
ptr727 merged commit e056c6f into develop Apr 13, 2026
23 checks passed
@ptr727
ptr727 deleted the prcodegen branch April 13, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants