Promotion prep: preserve CLAUDE.md endings; recast prose semicolons - #384
Merged
Conversation
…emicolons Pre-existing hygiene surfaced by the develop->main promotion review (#383). - host-setup/agent-safety/install.py: the CLAUDE.md append/update read via read_text and wrote via write_text, normalizing the file's line endings to the platform default instead of preserving them. Read bytes, work internally in LF, and write back with the file's own ending (CRLF if it has any), per the repo's preserve-endings-on-edit rule. (A verified append to a CRLF file now stays uniformly CRLF.) - docs/repo-config-carry.md: recast seven prose semicolons that joined independent clauses into commas or separate sentences, per AGENTS.md prose style. Shell-syntax and code-fence semicolons are left as-is. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses promotion-hygiene items so the upcoming develop -> main promotion carries clean content, focusing on preserving CLAUDE.md line endings during scripted edits and aligning documentation prose with the repo's no-prose-semicolons guideline.
Changes:
- Update
host-setup/agent-safety/install.pyto editCLAUDE.mdvia bytes, normalize internally to\n, and write back using the file's detected newline style (CRLF if present). - Recast prose semicolons in
docs/repo-config-carry.mdinto comma/period-separated sentences while leaving shell/code semicolons untouched.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| host-setup/agent-safety/install.py | Preserves CLAUDE.md newline style when appending/updating the agent-safety marker block. |
| docs/repo-config-carry.md | Adjusts prose punctuation to match repo documentation style expectations. |
Drop the two-line comment and the inline rule citation for the one-line default. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-existing hygiene items surfaced by Copilot on the
develop→mainpromotion review (#383). Fixing them ondevelopso the promotion carries clean content (the promotion's head isdevelop, so this lands here first).host-setup/agent-safety/install.py— the CLAUDE.md append/update normalized line endings (read_text/write_text) instead of preserving them. Now reads bytes, works internally in LF, and writes back with the file's own ending (CRLF if present), per the repo's preserve-endings rule. Verified: appending to a CRLF file stays uniformly CRLF, no mixing. (Copilot's specific "mixed\r\n\r\n\n" mechanism was inaccurate —read_textalready universal-newline-translates — but preserving endings is the correct behavior regardless.)docs/repo-config-carry.md— recast seven prose semicolons joining independent clauses (the four Copilot flagged plus three siblings) into commas/sentences, per AGENTS.md prose style. Shell-syntax and code-fence semicolons left as-is.markdownlint clean; install.py parses; EOL preserved.
🤖 Generated with Claude Code