Fix hub doc inconsistencies surfaced by Financial-Modeling adoption (#379 items 2, 3, 6) - #380
Merged
Merged
Conversation
…379) Quick/factual corrections from the first fidelity-audited adoptee: - catalog/snippets/workflows/README.md listed build-release-task/get-version-task as living in .github/workflows/ and omitted validate-task.yml. Correct the list to the actual tree: test-pull-request, publish-release, validate-task, merge-bot-pull-request (#379 item 6). - copilot-instructions.md named CODESTYLE's sections "(.NET, Python)", inaccurate once carried into a single-language repo. Generalize to "a section per language the repo uses" (#379 item 3). - repo-config/README.md is a carried file, not hub-only: drop its residual "mirrors the layout the fleet repos use" coordination reference, and add it to the spec/files.json manifest as an intent unit so the audit tracks it (it was carried in practice but unlisted, so downstream copies drifted unnoticed) (#379 item 2). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns hub governance/spec docs with the repo’s actual source-only workflow layout and with the fact that repo-config/README.md is a carried baseline file, reducing downstream drift during fidelity-based adoption.
Changes:
- Add
repo-config/README.mdtospec/files.jsonbaseline (intent/whole) so audits can flag missing/drifted downstream copies. - Remove the residual coordination-reference sentence from
repo-config/README.md. - Correct workflow-doc prose to match the repo’s actual
.github/workflows/orchestrator set and generalize the CODESTYLE language-section description.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
spec/files.json |
Adds repo-config/README.md to the baseline so audits can detect missing/drifted carried copies. |
repo-config/README.md |
Removes a coordination reference and keeps the file purely repo-local/descriptive. |
catalog/snippets/workflows/README.md |
Fixes the source-only orchestrator set listing to match the current .github/workflows/ tree (includes validate-task). |
.github/copilot-instructions.md |
Generalizes CODESTYLE’s per-language section description for single-language downstream repos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick/factual fixes from #379, filed by the Financial-Modeling agent as the first fidelity-audited adoptee. (Items 1, 4, 5 handled separately: item 1 is a no-change decision; items 4/5 — the source-only Release Model reconciliation — land in a follow-up PR.)
Changes
catalog/snippets/workflows/README.mdclaimed the hub keepsbuild-release-task/get-version-taskin.github/workflows/and omittedvalidate-task.yml. Corrected to the actual tree:test-pull-request,publish-release,validate-task,merge-bot-pull-request..github/copilot-instructions.mdnamed CODESTYLE's sections(.NET, Python), inaccurate once carried into a single-language repo. Generalized to "a section per language the repo uses".repo-config/README.mdis a carried file (each repo describes its ownrepo-config/), not hub-only. Dropped its one residual coordination reference ("mirrors the layout the fleet repos use"), and added it to thespec/files.jsonmanifest as anintentunit — it was carried in practice but unlisted, so downstream copies (e.g. finmod's) drifted unnoticed.Verification
spec/validate.pygreen (21 cataloged);spec/audit.py --selftestpass; live single-repo audit no-crash with the new manifest unit.Note: the new
intentunit means the next fleet audit will LETTER any repo missingrepo-config/README.md(correct — it belongs everywhere).🤖 Generated with Claude Code