Quote the exists comparison in D4; tighten the configure.sh comment - #318
Merged
Conversation
…#315) - WORKFLOW.md D4: the step output is the string 'false', so the documented gate compares 'false', matching the canonical workflows. - configure.sh: the fail-fast header comment drops to two lines. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes two forward-going review findings from the re-review of #315: clarifies that the exists step output used in release gating is a string, and shortens a fail-fast comment in configure.sh to better match the repo's comment-length guidance.
Changes:
- Update WORKFLOW.md D4 to document the gate as
exists == 'false' || workflow_dispatch(string output comparison). - Shorten the
repo-config/configure.shcomment describing why a missing/nameless ruleset payload must abort.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WORKFLOW.md | Corrects the documented exists gate to compare against the string 'false'. |
| repo-config/configure.sh | Tightens the fail-fast rationale comment while preserving intent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Copilot findings from the #315 promotion re-review, fixed forward: WORKFLOW.md D4 documents the gate as
exists == 'false'(the step output is a string), and the configure.sh fail-fast comment drops to two lines per the comment-length rule.🤖 Generated with Claude Code