Skip to content

Note the cspell gate scopes to whichever of README/HISTORY exists - #303

Merged
ptr727 merged 2 commits into
developfrom
fix/cspell-scope-history-optional
Jul 15, 2026
Merged

Note the cspell gate scopes to whichever of README/HISTORY exists#303
ptr727 merged 2 commits into
developfrom
fix/cspell-scope-history-optional

Conversation

@ptr727

@ptr727 ptr727 commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Feedback from the #302 fleet rollout: some repos (e.g. EspDinIoT, releaseTrigger: none) ship no HISTORY.md, and cspell errors on a listed file that does not exist.

Clarify in CODESTYLE.md § "Markdown and Spelling" that the README + HISTORY default scopes to whichever of the two the repo actually has — a repo with no changelog gates on README.md alone. Docs-only.

🤖 Generated with Claude Code

Fleet deployment feedback (#302 rollout): some
repos ship no HISTORY.md, and cspell errors on a listed file that does
not exist. Clarify that the README + HISTORY default degrades to
README-only where there is no changelog.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 15, 2026 16:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository style guide to clarify how the CI spelling gate should be scoped when a repo does not include both README.md and HISTORY.md, addressing fleet rollout feedback where cspell fails on missing files.

Changes:

  • Clarifies the intended cspell CI scope (README/HISTORY) in CODESTYLE.md.
  • Adds guidance for repos that do not ship HISTORY.md (or other gated files).

Comment thread CODESTYLE.md Outdated
Copilot review: the prior wording read as if the list auto-scoped. The
cspell file list is explicit, so a repo without HISTORY.md must remove
it from the workflow, task, and one-liner rather than relying on any
automatic behavior.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 15, 2026 16:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit 1693f60 into develop Jul 15, 2026
7 checks passed
@ptr727
ptr727 deleted the fix/cspell-scope-history-optional branch July 15, 2026 16:22
ptr727 added a commit that referenced this pull request Jul 15, 2026
Promotion of the cspell-scope work from develop to main.

- #302 — narrow CI cspell from all markdown to README.md + HISTORY.md;
codify the rule + rationale in CODESTYLE.md; AGENTS.md clarifier.
- #303 — note the list scopes to whichever of README/HISTORY the repo
has (repos with no changelog gate on README alone).

main still runs `**/*.md`; this brings it in line with the default.
Trial-merged clean locally — the promotion touches only the 3 cspell
files.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
ptr727 added a commit to ptr727/homeassistant-purpleair that referenced this pull request Jul 15, 2026
Docs-only change: append CODESTYLE item 3 "Spelling CI scope" under
**Markdown and Spelling**, documenting that the enforced CI spell-check
gate covers `README.md` + `HISTORY.md` only (not all markdown), with
broad live checking left to the cspell editor extension. Propagates the
template rule from ptr727/ProjectTemplate#302 and
ptr727/ProjectTemplate#303.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ptr727 added a commit to ptr727/NxWitness that referenced this pull request Jul 15, 2026
Docs-only: append a new "Spelling CI scope" item (item 3) to the
Markdown and Spelling list in CODESTYLE.md, documenting that the CI
spell-check gate covers README.md + HISTORY.md only while broad live
checking is the cspell editor extension's job. Propagates the template
rule from ptr727/ProjectTemplate#302 and ptr727/ProjectTemplate#303.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants