Follow-up: effective-model lineEndings check + $comment keyword - #293
Merged
Conversation
- spec/validate.py: require lineEndings by the *effective* workflow model (repo -> defaults.workflowModel -> release), matching configure.sh, so the invariant holds even if a repo relies on an operational defaults value. - registry/repos.schema.json: use the standard JSON Schema $comment annotation keyword (was a non-standard "comment"). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Tightens registry validation and schema annotations to align with the operational workflow-model behavior introduced in the develop -> main promotion series, ensuring lineEndings is required whenever a repo is effectively operational (including via defaults.workflowModel).
Changes:
- Update
spec/validate.pyto requirelineEndingsbased on the effective workflow model (repo.workflowModel -> defaults.workflowModel -> release), matchingconfigure.shbehavior. - Replace the non-standard JSON Schema
commentkeyword with the standard$commentannotation inregistry/repos.schema.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/validate.py | Enforces lineEndings when the effective workflow model resolves to operational, even when inherited from defaults. |
| registry/repos.schema.json | Uses JSON Schema standard $comment for the operational lineEndings requirement annotation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address Copilot review on the promotion PR #292:
spec/validate.py: requirelineEndingsby the effective workflow model (repo ->defaults.workflowModel-> release), matchingconfigure.sh.registry/repos.schema.json: use the standard$commentannotation keyword.🤖 Generated with Claude Code