codecov snippet: scope 'never gating' to Codecov's advisory statuses - #282
Merged
Conversation
The old comment 'Coverage is reported and trended, never gated' reads as absolute, but a repo can enforce a coverage floor separately (Python repos gate via pytest fail_under). Scope the claim to Codecov's statuses, which are advisory in every tier. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Codecov configuration snippet comment to accurately scope the "never gating" claim to Codecov's coverage statuses (which are configured as advisory via informational: true), avoiding confusion with coverage gating that can occur elsewhere (e.g., test runners enforcing thresholds).
Changes:
- Reword the header comment to clarify that only Codecov's coverage status checks are advisory and non-blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canonical codecov.yml comment said 'Coverage is reported and trended, never gated', which is misleading: Python repos gate coverage via pytest
fail_under. Scope the claim to Codecov's advisory statuses (true in every tier). Surfaced by Copilot on aiopurpleair #27; the two Python repos in flight already carry the reworded comment.