Skip to content

Coverage hygiene: gitignore coverage output + codecov.yml standard - #273

Merged
ptr727 merged 5 commits into
developfrom
feature/coverage-hygiene
Jul 10, 2026
Merged

Coverage hygiene: gitignore coverage output + codecov.yml standard#273
ptr727 merged 5 commits into
developfrom
feature/coverage-hygiene

Conversation

@ptr727

@ptr727 ptr727 commented Jul 9, 2026

Copy link
Copy Markdown
Owner

Closes two coverage gaps surfaced while working on Utilities.

1. .gitignore swept in coverage output. CI writes coverage to ./coverage/ (C#) and coverage.xml/.coverage (Python), but the template .gitignore excluded none of it — so git add -A committed a coverage.cobertura.xml build artifact. Added: coverage/, [Tt]est[Rr]esults/, *.cobertura.xml, *.coverage, coverage.xml, .coverage, .coverage.*, htmlcov/.

2. codecov.yml was not standardized. The upload path was covered (D1.6) but not the file that makes Codecov's own project/patch commit statuses non-gating — a different knob from fail_ci_if_error. Added a reference catalog/snippets/configs/codecov.yml (informational: true + a commented ignore: for untested example/benchmark apps), listed it in spec/files.json for ["csharp","python"], and extended WORKFLOW.md D1.6.

CRLF preserved; editorconfig-checker + markdownlint + spec/validate.py all clean.

Follow-ups (authorized, next): local lint parity (husky + VS Code tasks mirror the CI lint set incl editorconfig-checker), then bundled backfill of codecov.yml + hygiene to the 5 C# repos.

🤖 Generated with Claude Code

.gitignore now excludes coverage artifacts (coverage/, *.cobertura.xml,
coverage.xml, .coverage, htmlcov/) so a blanket git add -A never commits
them. Add a reference codecov.yml snippet (project+patch informational so
a coverage delta never gates a PR - distinct from fail_ci_if_error - plus
a commented ignore for untested example/benchmark apps), list it in
spec/files.json for csharp/python, and extend WORKFLOW.md D1.6.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 9, 2026 23:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens coverage hygiene in the template/spec by (1) ensuring common coverage outputs are ignored by default and (2) standardizing a baseline codecov.yml so Codecov statuses are explicitly non-gating across C# and Python repos.

Changes:

  • Extend .gitignore to exclude common C# and Python coverage outputs (including directory-based outputs like coverage/ and htmlcov/).
  • Add a baseline codecov.yml reference snippet that sets Codecov project/patch statuses to informational: true.
  • Update spec/files.json and WORKFLOW.md (D1.6) to codify the codecov.yml and coverage-artifact expectations.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
WORKFLOW.md Expands D1.6 to document Codecov non-gating behavior and coverage-artifact hygiene expectations.
spec/files.json Adds codecov.yml to the baseline for ["csharp","python"], referencing the catalog snippet.
catalog/snippets/configs/codecov.yml Introduces the standard Codecov config snippet (non-gating statuses; optional ignore guidance).
.gitignore Ignores common coverage outputs to prevent accidental commits from git add -A.

Comment thread WORKFLOW.md Outdated
The contract doc points at .gitignore as the source of truth rather than
duplicating the full pattern set (avoids two places to maintain).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 10, 2026 00:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

Comment thread WORKFLOW.md Outdated
…ed coverage output)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 10, 2026 00:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

Comment thread WORKFLOW.md Outdated
Comment thread catalog/snippets/configs/codecov.yml Outdated
…t HA-specific

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 10, 2026 00:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

Comment thread catalog/snippets/configs/codecov.yml Outdated
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 10, 2026 00:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit 266019e into develop Jul 10, 2026
7 checks passed
@ptr727
ptr727 deleted the feature/coverage-hygiene branch July 10, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants