docs: polish from #271 review (PR-link placeholder + NullLoggerFactory.Instance) - #272
Merged
Conversation
…gerFactory.Instance AGENTS.md: use OWNER/REPO placeholder (no angle brackets) in the clickable-PR-link example. CODESTYLE.md: the library logger seam defaults to NullLoggerFactory.Instance (the singleton), matching LanguageTags. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Polishes governance documentation wording to make placeholder examples render cleanly and to align the .NET logging guidance with the recommended NullLoggerFactory singleton usage.
Changes:
- Adjust AGENTS.md's clickable PR link example to use
OWNER/REPOinstead of<owner>/<repo>placeholders. - Update CODESTYLE.md's library logging seam guidance to default to
NullLoggerFactory.Instance(singleton) rather than the type name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AGENTS.md | Tweaks the example PR link placeholder to avoid angle-bracket placeholders that can render poorly in markdown/HTML contexts. |
| CODESTYLE.md | Clarifies the recommended default logger factory to the singleton NullLoggerFactory.Instance to match typical Microsoft.Extensions.Logging usage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two one-line doc tweaks deferred from the #271 promotion review:
OWNER/REPO(no angle brackets that render oddly) instead of<owner>/<repo>.NullLoggerFactory.Instance(the singleton), matching the LanguageTagsLogOptionsreference.Docs-only; markdownlint clean; CRLF preserved.
🤖 Generated with Claude Code