Conversation
…sion recommendations Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
* Branding Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> * Allow only squash merging Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Clarify the requirements for merge rules in the README and ensure all general merge types are enabled for rulesets to be honored. --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Enhance the README for clearer setup instructions and update branding for consistency. Adjust merge rules and clarify requirements in the documentation. Include additional project files and configurations to support development and code generation tasks. --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Improve the logging framework with global configuration options and refactor the code structure. Enhance documentation across multiple files and add agent instructions for better clarity. --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Improve code structure and documentation across multiple files, enhance the logging framework with global configuration options, and update the testing framework references. Additionally, reorganize the README to clarify branching workflow requirements. --------- Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request represents a major refactoring and modernization of the ProjectTemplate codebase. The changes transform the template from a basic structure into a comprehensive, production-ready template demonstrating modern .NET development best practices.
Changes:
- Upgraded testing framework from xUnit v2 to xUnit v3 with comprehensive logging tests
- Introduced a new logging architecture using Microsoft.Extensions.Logging abstractions with Serilog integration
- Added a new CodeGen project demonstrating code generation patterns and API integration
- Completely restructured Console application with improved command-line parsing and logging
- Enhanced documentation with CODESTYLE.md, AGENTS.md, and HISTORY.md
- Reorganized GitHub Actions workflows with clearer naming and improved task structure
- Removed deprecated code and dependencies (ProcessTask, AOT build configurations)
Reviewed changes
Copilot reviewed 63 out of 65 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Tests.csproj | Upgraded to xUnit v3, added test project properties, removed Console dependency |
| Tests/SampleTest.cs | Simplified tests with improved naming following MethodName_Scenario_ExpectedBehavior pattern |
| Tests/LoggingTests.cs | New comprehensive logging tests covering LogOptions and factory patterns |
| Tests/Fixture.cs | Refactored to use xUnit v3 AssemblyFixture and collection fixtures |
| Library/Library.csproj | Simplified dependencies to Microsoft.Extensions.Logging.Abstractions, conditional AOT verification |
| Library/Options.cs | New options class for library configuration with ILoggerFactory and ILogger support |
| Library/LogOptions.cs | New global logging configuration with thread-safe factory and logger management |
| Library/Library.cs | New library implementation with lazy logger initialization |
| Library/Extensions.cs | Refactored to use LoggerMessage source generator for performance |
| Console/Console.csproj | Simplified project configuration, removed AOT by default, updated dependencies |
| Console/Program.cs | Major refactor using primary constructors and improved error handling |
| Console/CommandLine.cs | Complete rewrite with better option handling and subcommand support |
| Console/LoggerFactory.cs | New factory implementation bridging Serilog and Microsoft.Extensions.Logging |
| Console/Extensions.cs | Dual extension methods for both Serilog and Microsoft.Extensions.Logging ILogger |
| CodeGen/*.cs | New code generation project with API integration example |
| README.md | Comprehensive documentation rewrite with detailed usage and setup instructions |
| CODESTYLE.md | New code style guide documenting all project conventions |
| AGENTS.md | New AI agent instructions for maintaining consistency |
| HISTORY.md | New release history documentation |
| .github/workflows/* | Reorganized workflows with clearer naming (action/task/job suffixes) |
| .editorconfig | Updated with ReSharper settings and modifier order improvements |
| Benchmarks/*.csproj | Simplified project properties |
| Docker/Dockerfile | Removed unused AOT dependencies |
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
#27) …improve branch condition checks Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com> Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.