Require a matching editorconfig override for extensionless-script and data pins - #240
Merged
Merged
Conversation
… data pins AGENTS.md line-ending guidance told repos to add a .gitattributes LF pin for extensionless scripts (husky, s6) but not the matching .editorconfig override. .gitattributes governs git; the editor follows .editorconfig, where [*] end_of_line = crlf still applies to files no extension rule covers - so the editor writes a CRLF shebang into an extensionless hook, or re-ends/trims byte-sensitive data, even with the git pin. Require the paired editorconfig LF override for extensionless executables and full-unset overrides for byte-preserve data dirs. Closes the divergence found in the fleet EOL convergence. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository governance guidance in AGENTS.md to close a documented gap between .gitattributes (git checkout/commit behavior) and .editorconfig (editor save behavior) for extensionless executables and byte-sensitive content.
Changes:
- Adds an explicit requirement to pair extensionless-script
.gitattributesLF pins with matching.editorconfigpath overrides. - Extends the guidance to “byte-preserve” data directories by describing how to prevent editor-driven normalization.
Note inline that unset removes an inherited property (charset/end_of_line), so the guidance reads unambiguously. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the gap the fleet EOL convergence surfaced: AGENTS.md told repos to add a
.gitattributesLF pin for extensionless scripts, but not the matching editorconfig override..gitattributesgoverns git; the editor follows.editorconfig, where[*] end_of_line = crlfstill applies to files no extension rule covers - so the editor writes a CRLF shebang into.husky/pre-commit(breaking it), or re-ends/trims byte-sensitive data, even with the git pin.Requires: an editorconfig LF override beside each extensionless-executable git pin (
[.husky/pre-commit] end_of_line = lf), and full-unset overrides for byte-preserve data dirs (charset/end_of_lineunset,insert_final_newline/trim_trailing_whitespacefalse). This is exactly why Utilities carried the husky override while PlexCleaner/LanguageTags did not.🤖 Generated with Claude Code