Skip to content

Write upstream-version state file as CRLF to honor the JSON rule #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptr727 merged 2 commits into from
Jun 21, 2026
Merged

Write upstream-version state file as CRLF to honor the JSON rule #172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9754ee8
Write upstream-version state file as CRLF to honor the JSON rule
ptr727 Jun 21, 2026
d14c090
Trim state-file write comment
ptr727 Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/check-upstream-version-task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,9 @@ jobs:
# (a valid-JSON-but-non-object file would otherwise break the `$old + $new` union below).
if [ -f "$STATE_FILE" ] && old="$(jq -S 'if type == "object" then . else empty end' "$STATE_FILE" 2>/dev/null)" && [ -n "$old" ]; then :; else old='{}'; fi

# Write the canonical (sorted, pretty) state file. A prior file already in this exact
# form yields no diff, so create-pull-request opens nothing; a semantically identical
# file with different formatting still changes and opens a canonicalize-only PR (titled
# as such below).
printf '%s\n' "$new" > "$STATE_FILE"
# Write the canonical state file as CRLF (jq emits LF) to match .editorconfig's .json
# rule. Unchanged content => no diff => no PR.
printf '%s\n' "$new" | sed 's/$/\r/' > "$STATE_FILE"

# Diff across the union of old+new keys so an added, moved, or removed key is all caught;
# removals carry a null .new. These drive the PR title/body (only keys that moved).
Expand Down