Decouple GitHub-release assembly from per-target builds - #109
Merged
Conversation
The github-release job collected release files by referencing specific build jobs (build-nugetlibrary, build-executable) by artifact-id, so a non-.NET downstream had to fork build-release-task.yml to attach its own artifact, and a .NET project that subset targets hit an empty-id download for the dropped target. Collect release assets by the release-asset-<branch>-* artifact convention instead: leaf tasks upload under that name and the github-release job downloads them by pattern, never naming a build job. The release orchestration (tag, create release, attach assets) is now reusable verbatim and target subsetting no longer breaks the download. Document the orchestration-vs-build seam and the no-op republish guarantee in AGENTS.md and README.md. Fixes #108
Contributor
There was a problem hiding this comment.
Pull request overview
This PR decouples GitHub Release asset assembly from specific per-target build jobs by introducing a stable artifact-naming contract (release-asset-<branch>-<target>) and updating the release orchestrator to collect assets by pattern. This makes the release orchestration more reusable for downstream/derived projects and avoids tight coupling to a fixed set of build targets.
Changes:
- Update
github-releaseto download release assets viaactions/download-artifactpattern matching (release-asset-<branch>-*) instead of per-jobartifact-idoutputs. - Rename NuGet/executable release artifacts to the new
release-asset-<branch>-{nugetlibrary,executable}convention and remove now-unusedartifact-idoutputs. - Document the orchestration-vs-build “override seam” and the no-op republish behavior in
AGENTS.mdandREADME.md.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the reuse seam and clarifies two-phase publish/no-op republish behavior. |
| AGENTS.md | Adds authoritative guidance for downstreams on orchestration vs. build responsibilities and the release-asset-* contract. |
| .github/workflows/build-release-task.yml | Switches GitHub Release asset collection to pattern-based artifact downloads. |
| .github/workflows/build-nugetlibrary-task.yml | Renames uploaded release artifact to release-asset-<branch>-nugetlibrary and removes artifact-id outputs. |
| .github/workflows/build-executable-task.yml | Renames uploaded release artifact to release-asset-<branch>-executable and removes artifact-id outputs. |
The download-step comment implied a target gated off via enable_*: false just contributes no artifact, but github-release needs those jobs, so a skipped build job skips the release too. Describe the per-target deletion model and note download-artifact@v7 tolerates a zero-match pattern.
ptr727
added a commit
that referenced
this pull request
Jun 5, 2026
Release of develop → main. Carries three changes: - **Decouple GitHub-release assembly from per-target builds (#109)** — `github-release` collects assets by the `release-asset-<branch>-*` convention instead of naming build jobs, so the release orchestration is reusable verbatim by downstreams. Fixes #108. - **Back-port CI/CD fixes discovered during the PlexCleaner port (#107)** — commit-pinned release leaves, event-aware github-release gating, Docker cache-export tolerance, publish concurrency scoping, smoke-build gating, badge filtering, Copilot runbook login fix. - **Update codegen files (#106).** Merge-commit (not squash) per the branching model, so main records develop's tip as the second parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
github-releasejob assembled release assets by referencing specific build jobs (build-nugetlibrary,build-executable) byartifact-id. That coupling meant a non-.NET downstream had to forkbuild-release-task.ymlto attach its own artifact, and a .NET project that subset targets (dropped the executable, kept NuGet) hit an empty-artifact-iddownload for the dropped target.This introduces a convention — a target contributes files to the GitHub release by uploading a workflow artifact named
release-asset-<branch>-<target>— and makesgithub-releasecollect them by pattern (release-asset-<branch>-*,merge-multiple) instead of naming any build job.Why
Resolves #108: the release orchestration (tag the built commit, create the release, attach assets) is now reusable verbatim by any downstream — a non-.NET project swaps a leaf task instead of forking the orchestrator. Also fixes the latent subsetting bug for .NET downstreams.
Changes
build-nugetlibrary-task.yml/build-executable-task.yml: rename release artifacts torelease-asset-<branch>-{nugetlibrary,executable}; drop the now-unusedartifact-idoutputs.build-release-task.yml:github-releasecollects assets via pattern download;needsretained for ordering (a gated-off target simply contributes no artifact).AGENTS.md/README.md: document the orchestration-vs-build seam (with an output-type customization guide) and the no-op republish guarantee.Docker (Docker Hub) and PyPI (its own publish job) contribute no
release-asset-*and are unchanged.actionlintwas not run locally (not installed in this environment); workflows parse as valid YAML.Fixes #108