Skip to content

local-strict-review skill copies AGENTS.md's subagent briefing template instead of referencing it #1070

Description

@ptr727

What happened

Qodo, reviewing PR #1068 (develop -> main promotion carrying #1065's local-strict-review skill), flagged that .agents/skills/local-strict-review/SKILL.md's "Running It" section copies structural content from AGENTS.md's "Context and Delegation Discipline" subagent-briefing template rather than only referencing it. Concretely, the closing sentence of the templated brief in local-strict-review/SKILL.md ("If a rule you were given does not cover what you find, stop and report it. Do not guess, and do not read a governance file to resolve it.") is copied verbatim from AGENTS.md's own template (line 68), rather than referenced.

Why this matters

comment-and-doc-style and the fleet's general carried-content convention prefer referencing canonical governance text over restating it, since a restated copy can silently drift from the canonical wording if AGENTS.md's template changes later. The rest of the "Running It" section is a legitimate concrete task-specific instantiation of the template (the actual Task:/Paths:/Rules:/Return:/Bounds: content is unique to this skill), so the fix is narrower than "stop instantiating the template" — it's specifically about the generic closing boilerplate sentence being copied rather than referenced.

Where this was raised

PR #1068 (develop -> main promotion), Qodo review round, 2026-08-28. Deferred here rather than fixed mid-review since the flagged content belongs to PR #1065 (already merged), not the PR the finding was raised against.

Suggested fix

Either drop the closing sentence from local-strict-review/SKILL.md's template instantiation and let the pointer to AGENTS.md "Context and Delegation Discipline" (already present in the skill's "Mechanics Live Elsewhere" section) cover it, or replace it with a short explicit reference ("same closing line as AGENTS.md's own template") rather than the verbatim copy. Apply identically across all three mirrored copies (.agents/skills/local-strict-review/SKILL.md, .claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md, .github/skills/local-strict-review/SKILL.md) via scripts/build_dist.py.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions