Sync Carried Fleet Skills - #69
Conversation
There was a problem hiding this comment.
Pull request overview
Syncs the carried fleet Skill tree from the ProjectTemplate hub into PhotoCleaner, updating task/worktree setup guidance, Python tooling guidance, and PR review-loop guidance so contributor workflows (hooks, verification, review gating) stay consistent across the fleet.
Changes:
- Extend
repo-worktreeSkill guidance to include immediate Git hook preparation for new worktrees (Husky.Net and Python pre-commit). - Update
python-codestyleSkill guidance to emphasize reading repo-specific verification commands (OPERATIONS.md) before selecting Python tooling/profile. - Update
pr-review-conductSkill guidance to treat PR opening as part of the review loop and to incorporatepr_review.pystatus/wait steps.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/skills/repo-worktree/SKILL.md | Adds “Preparing Git Hooks” guidance and updates the Skill description to include hook setup during worktree preparation. |
| .github/skills/python-codestyle/SKILL.md | Refines trigger/usage language and adds explicit direction to consult OPERATIONS.md before choosing Python commands/profile. |
| .github/skills/pr-review-conduct/SKILL.md | Expands the expected PR review loop (including PR opening) and references status/wait mechanics via pr_review.py. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/skills/pr-review-conduct/SKILL.md:75
- Steps 4 and 5 both instruct the reader to wait for review activity, which makes the numbered procedure ambiguous (it reads like two separate wait steps). Combine them into a single step and renumber the remainder so the loop stays unambiguous.
4. Run a bounded `scripts/pr_review.py wait` in a background process and read its terminal output.
5. Wait for review activity on that head. A completed review raising **no findings** is a valid
terminal outcome, so don't re-trigger it or read silence as a missing review. A review whose
body says it declined to review is the one exception, and it is terminal the other way:
nothing follows it, and re-requesting the same head just repeats the decline.
|
Suppressed findings (1) from https://github.com/ptr727/PhotoCleaner/pull/69#pullrequestreview-4965348211\n\n> .github/skills/pr-review-conduct/SKILL.md:75 - Steps 4 and 5 both instruct the reader to wait for review activity, making the numbered procedure ambiguous.\n\nFixed in 734fa68. The canonical skill now combines the wait command and its terminal-outcome guidance into one step and renumbers the remainder. ProjectTemplate released the correction on main at 4596659, and this branch was refreshed from that revision. |
|
Suppressed findings (1) from #69 (review)
Fixed in 734fa68. The canonical skill combines the wait command and its terminal-outcome guidance into one step and renumbers the remainder. ProjectTemplate released the correction on main at 4596659, and this branch was refreshed from that revision. |
Summary
b74811bWhy
A fresh PhotoCleaner worktree contains
.husky/pre-commitbut not the generated.husky/_/husky.shruntime. The carried worktree skill now restores and installs Husky.Net before the first commit.This propagates ptr727/ProjectTemplate#815 and completes #61.
Verification
dotnet tool restoredotnet husky installdotnet csharpier format --log-level=debug .dotnet builddotnet format style --verify-no-changes --severity=info --verbosity=detaileddotnet test(368 passed, 5 skipped)dotnet husky runb74811b