Kill the docker probe when its wait times out

[ptr727]

Answers a suppressed Copilot finding raised on the develop to main promotion PR #45, on its head 0335970. That review carried no inline comment, so the PR read as having nothing outstanding.

The finding

PhotoCleanerTests/VerifyTaskTests.cs:502 - In ImmichImageAvailable(), if docker image inspect hangs and WaitForExit times out, the method returns false without terminating the child process. That can leak a running docker process into the test run and potentially affect subsequent tests.

Correct. The helper starts docker image inspect and returns false on a 60-second timeout. The using disposes the Process, but disposal frees the handles rather than ending the child, so the probe outlives the test that started it and keeps running alongside the rest of the suite.

Verified rather than assumed

Process.Dispose semantics are easy to state wrongly, so a standalone probe checked them instead. A child started the same way and left to Dispose alone was still present in /proc after the using block exited. The same child, killed first, was gone.

kill=False child pid <redacted> still running after dispose: True
kill=True  child pid <redacted> still running after dispose: False

The fix

Kill(entireProcessTree: true) runs before the false return. The InvalidOperationException catch covers the child exiting between the timeout expiring and the kill landing, which is a real race rather than defensive padding. A Win32Exception from the kill falls through to the existing catch on the enclosing block, which already returns false.

Verification

• CSharpier Format, .NET Build, dotnet format style --verify-no-changes: clean, 0 of 57 files, 0 warnings.
• dotnet husky run: pass.
• dotnet test: 372 passed, 0 failed, 0 skipped. The zero matters here: the Immich image is present on this host, so the Docker-gated tests ran rather than skipping, which means this helper was actually exercised.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.37%. Comparing base (0335970) to head (0f49a28).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop      #47   +/-   ##
========================================
  Coverage    43.37%   43.37%           
========================================
  Files           28       28           
  Lines         3896     3896           
  Branches       306      306           
========================================
  Hits          1690     1690           
  Misses        2154     2154           
  Partials        52       52           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Updates the Docker preflight helper used by VerifyTaskTests to ensure a timed-out docker image inspect probe doesn’t leave a stray docker process running during the test suite.

Changes:

• When WaitForExit(60_000) times out, the probe now attempts to Kill(entireProcessTree: true) before returning false.
• Adds comments explaining why disposal alone is insufficient in this scenario.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.