Raise the version floor to match the 1.1 declared in HISTORY.md - #43
Merged
Conversation
HISTORY.md declares Version 1.1 for the verify command and the breaking exit-code changes, while version.json still floored at 1.0, so the next release cut from main would have been 1.0.18 and contradicted it. Only version.json moves. The Version and InformationalVersion properties in PhotoCleaner.csproj are local-build placeholders that CI overrides with the values Nerdbank.GitVersioning computes, so they do not track this file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR aligns the Nerdbank.GitVersioning version floor with the 1.1 version declared in HISTORY.md, ensuring the next release cut from main will not produce a 1.0.x version that contradicts the shipped changelog.
Changes:
- Update
version.jsonto raise the version floor from1.0to1.1.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #43 +/- ##
========================================
Coverage 43.37% 43.37%
========================================
Files 28 28
Lines 3896 3896
Branches 306 306
========================================
Hits 1690 1690
Misses 2154 2154
Partials 52 52 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HISTORY.md declares
**Version: 1.1**for theverifycommand and the breaking exit-code changes, whileversion.jsonstill floored at1.0. Nerdbank.GitVersioning computes the release version from that floor, so the next release cut frommainwould have been1.0.18and contradicted the changelog it ships with. Latest release is1.0.17.Only
version.jsonmoves. TheVersionandInformationalVersionproperties inPhotoCleaner/PhotoCleaner.csprojare local-build placeholders:get-version-task.ymlruns NBGV once and threadsAssemblyVersion,AssemblyFileVersionandAssemblyInformationalVersioninto the build jobs, so the csproj values never reach a published artifact and do not track this file.This lands ahead of the
developtomainpromotion so the version floor is correct before any release is cut.Verification
CSharpier Format,.NET Build,dotnet format style --verify-no-changes: clean, 0 of 57 files formatted, 0 warnings.dotnet husky run: pass.dotnet test: 372 passed, 0 failed, 0 skipped.