Skip to content

Revert the Docker Hub short description mechanism - #33

Merged
ptr727 merged 0 commit into
developfrom
revert/dockerhub-short-description
Aug 1, 2026
Merged

Revert the Docker Hub short description mechanism#33
ptr727 merged 0 commit into
developfrom
revert/dockerhub-short-description

Conversation

@ptr727

@ptr727 ptr727 commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Reverts #32 (90504d38e274dad1dd1894dee7fe47d1881ae91f).

Nothing is wrong with the implementation. It is the wrong place for it.

Setting the Docker Hub short description from the README intro affects every docker project in the fleet, and the hub already owns the audit half of it: spec/audit.py flags a short description that has drifted from the README intro, on any repo. Adding the push half in one repo leaves that repo diverged from every other docker project and pre-empts a decision that is not this repo's to make.

The hub is working out a deterministic approach. This returns the repo to the audit-only state so it matches the fleet while that happens, and so a later develop -> main promotion cannot carry the mechanism silently.

Why it merged in the first place

The maintainer authorized merging six conformance PRs. #32 was opened afterwards, as the mechanism behind a Docker Hub description change that had been authorized separately, and I extended that merge authorization to it rather than asking. That was mine to ask, not to assume.

Practically the exposure was nil: both added steps are gated inputs.push && inputs.branch == 'main', #32 landed on develop only, and no promotion or publish has run since, so nothing was ever pushed to Docker Hub.

What is preserved

The implementation and its ten test cases are on #32 and in this branch's history, so the hub can lift it as-is if it wants the push half. The guards it accumulated over three review rounds are the part worth keeping:

  • markdown structure after the H1 (headings, lists, quotes, tables, fences, HTML, badges, tilde fences, ordered lists)
  • inline and reference links
  • the 100-character Docker Hub cap
  • CRLF handling and leading-whitespace trimming, since CommonMark allows 3 leading spaces before a heading

Verification

Copilot AI review requested due to automatic review settings August 1, 2026 17:22
@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.96%. Comparing base (90504d3) to head (379d1ff).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #33   +/-   ##
========================================
  Coverage    44.96%   44.96%           
========================================
  Files           25       25           
  Lines         3398     3398           
  Branches       259      259           
========================================
  Hits          1528     1528           
  Misses        1824     1824           
  Partials        46       46           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the Docker Hub short-description update mechanism that was previously added to the Docker build/publish workflow, returning the repository to an audit-only state that matches the rest of the fleet’s docker projects.

Changes:

  • Removed the workflow step that parsed README.md to derive a Docker Hub short description.
  • Removed the short-description: input wiring into the Docker Hub description update action.

@ptr727
ptr727 merged this pull request into develop Aug 1, 2026
14 checks passed
@ptr727
ptr727 deleted the revert/dockerhub-short-description branch August 1, 2026 17:24
ptr727 added a commit that referenced this pull request Aug 3, 2026
This reverts commit 90504d38e274dad1dd1894dee7fe47d1881ae91f (#32).

Nothing is wrong with the implementation. It is the wrong place for it.
Setting the Docker Hub short description from the README intro affects
every docker project in the fleet, and the hub already owns the audit
half: spec/audit.py flags a short description that has drifted from the
README intro. Adding the push half in one repo leaves that repo diverged
from every other docker project and pre-empts a decision that is not the
repo's to make.

The hub is working out a deterministic approach. This reverts to the
audit-only state so the repo matches the fleet while that happens, and
so a later develop -> main promotion cannot carry the mechanism silently.

The workflow is now byte-identical to its state before #32, and the
implementation with its ten test cases is preserved in #32 for whoever
picks the decision up.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants