Revert the Docker Hub short description mechanism - #33
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #33 +/- ##
========================================
Coverage 44.96% 44.96%
========================================
Files 25 25
Lines 3398 3398
Branches 259 259
========================================
Hits 1528 1528
Misses 1824 1824
Partials 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR reverts the Docker Hub short-description update mechanism that was previously added to the Docker build/publish workflow, returning the repository to an audit-only state that matches the rest of the fleet’s docker projects.
Changes:
- Removed the workflow step that parsed
README.mdto derive a Docker Hub short description. - Removed the
short-description:input wiring into the Docker Hub description update action.
This was referenced Aug 1, 2026
ptr727
added a commit
that referenced
this pull request
Aug 3, 2026
This reverts commit 90504d38e274dad1dd1894dee7fe47d1881ae91f (#32). Nothing is wrong with the implementation. It is the wrong place for it. Setting the Docker Hub short description from the README intro affects every docker project in the fleet, and the hub already owns the audit half: spec/audit.py flags a short description that has drifted from the README intro. Adding the push half in one repo leaves that repo diverged from every other docker project and pre-empts a decision that is not the repo's to make. The hub is working out a deterministic approach. This reverts to the audit-only state so the repo matches the fleet while that happens, and so a later develop -> main promotion cannot carry the mechanism silently. The workflow is now byte-identical to its state before #32, and the implementation with its ten test cases is preserved in #32 for whoever picks the decision up. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #32 (
90504d38e274dad1dd1894dee7fe47d1881ae91f).Nothing is wrong with the implementation. It is the wrong place for it.
Setting the Docker Hub short description from the README intro affects every
dockerproject in the fleet, and the hub already owns the audit half of it:spec/audit.pyflags a short description that has drifted from the README intro, on any repo. Adding the push half in one repo leaves that repo diverged from every other docker project and pre-empts a decision that is not this repo's to make.The hub is working out a deterministic approach. This returns the repo to the audit-only state so it matches the fleet while that happens, and so a later
develop -> mainpromotion cannot carry the mechanism silently.Why it merged in the first place
The maintainer authorized merging six conformance PRs. #32 was opened afterwards, as the mechanism behind a Docker Hub description change that had been authorized separately, and I extended that merge authorization to it rather than asking. That was mine to ask, not to assume.
Practically the exposure was nil: both added steps are gated
inputs.push && inputs.branch == 'main', #32 landed ondeveloponly, and no promotion or publish has run since, so nothing was ever pushed to Docker Hub.What is preserved
The implementation and its ten test cases are on #32 and in this branch's history, so the hub can lift it as-is if it wants the push half. The guards it accumulated over three review rounds are the part worth keeping:
Verification
git diff 95af4d7 HEADis empty:build-docker-task.ymlis byte-identical to its state before Set the Docker Hub short description from the README intro #32.short-descriptionremain in the workflow.actionlintexits 0;editorconfig-checkerexits 0.