Re-vendor the stale markdownlint and configure.sh carries - #27
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #27 +/- ##
========================================
Coverage 44.96% 44.96%
========================================
Files 25 25
Lines 3398 3398
Branches 259 259
========================================
Hits 1528 1528
Misses 1824 1824
Partials 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR re-vendors two carried “verbatim” files to match the current upstream template baseline, ensuring this repo’s lint and fleet-configuration tooling stays in sync with the hub canonical.
Changes:
- Relax
.markdownlint-cli2.jsoncMD033 to allow only<details>/<summary>for GitHub collapsibles while keeping other inline HTML disallowed. - Harden
repo-config/configure.shby failing loudly on ruleset list truncation (per_page=100cap) and by adding explicit failure guards for several previously-unguarded reads. - Reflow comments to one sentence per line for consistency/readability without changing meaning.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
repo-config/configure.sh |
Adds defensive guards to avoid false passes/partial application when API reads fail or ruleset listing hits the per-page cap. |
.markdownlint-cli2.jsonc |
Updates markdownlint configuration to permit GitHub collapsible markup without opening up other inline HTML. |
ptr727
added a commit
that referenced
this pull request
Aug 3, 2026
Both files are declared verbatim in the hub's spec/files.json, and the audit reports each as matching a past hub revision rather than the current canonical. markdownlint gains MD033 allowed_elements for details and summary, so GitHub collapsibles pass while every other inline element still flags. configure.sh gains a per_page cap guard in ruleset_id, which fails loud rather than silently narrowing a lookup that would let apply create a duplicate ruleset by name, plus explicit failure guards on the missing ruleset payload, the id resolve, the live ruleset read, and the repository settings read, so an API error is a clean FAIL rather than a set -e abort or a false pass. The remaining hunks are the comment reflow to one sentence per line. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both files are declared
verbatimin the hub'sspec/files.json, and the audit reports each as matching a past hub revision rather than the current canonical, so the base advanced and this repo's copies did not.Both files are now byte-identical to
ptr727/ProjectTemplate@6501479.What changed beyond the comment reflow
.markdownlint-cli2.jsoncgainsMD033: { allowed_elements: ["details", "summary"] }, so GitHub collapsibles pass while every other inline element still flags. This only relaxes a rule, so it cannot introduce a new lint failure.repo-config/configure.shgains real behavior:per_pagecap guard inruleset_id: a full page of 100 means the single-fetch assumption no longer holds, and a missed lookup would makeapplycreate a duplicate ruleset by name. It now aborts instead.FAILrather than aset -eabort or a false pass.The remaining hunks are the comment reflow to one sentence per line.
Verification
diffagainst the hub canonical is empty for both files.configure.shretains mode 755 and LF endings;editorconfig-checkeris clean over the tree.Part of the conformance sweep against the hub baseline (
audit run 2026-08-01T14:29:05Z | hub 6501479).