Skip to content

Fix CODESTYLE spelling rule: US English only, document CI scope - #11

Merged
ptr727 merged 0 commit into
developfrom
docs/spelling-us-english-ci-scope
Jul 15, 2026
Merged

Fix CODESTYLE spelling rule: US English only, document CI scope#11
ptr727 merged 0 commit into
developfrom
docs/spelling-us-english-ci-scope

Conversation

@ptr727

@ptr727 ptr727 commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Three factual corrections to CODESTYLE.md's Markdown/Spelling section:

  • Spelling said "US or UK English", which contradicts the fleet US-only convention (cspell.json pins "language": "en-US"). Corrected to US English.
  • Markdown linting was marked "local only; no CI", but CI (validate-task.yml) runs markdownlint. Corrected.
  • Documented the CI spell-check scope (README.md + HISTORY.md), matching Scope CI spell-check to README and HISTORY by default ProjectTemplate#302, #303.

Note: PhotoCleaner's CODESTYLE.md predates the template's General/.NET/Python restructure. This PR is a targeted correctness fix, not the full structural modernization (flagged separately).

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings July 15, 2026 18:41
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.39%. Comparing base (17dcf37) to head (3c935b5).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #11   +/-   ##
========================================
  Coverage    44.39%   44.39%           
========================================
  Files           25       25           
  Lines         3347     3347           
  Branches       253      253           
========================================
  Hits          1486     1486           
  Misses        1819     1819           
  Partials        42       42           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates PhotoCleaner’s contributor coding style guide to match the repository’s actual CI/editor enforcement, keeping documentation rules accurate and consistent with the tooling configuration.

Changes:

  • Corrects the spelling convention to US English only (matching cspell.json).
  • Corrects Markdown linting guidance to reflect that CI runs markdownlint.
  • Documents the CI spell-check scope as README.md and HISTORY.md only.

@ptr727
ptr727 merged this pull request into develop Jul 15, 2026
6 checks passed
@ptr727
ptr727 deleted the docs/spelling-us-english-ci-scope branch July 15, 2026 18:45
ptr727 added a commit that referenced this pull request Aug 3, 2026
Three factual corrections in the Markdown/Spelling section:
- Spelling was "US or UK English", contradicting the fleet US-only rule
  (cspell.json pins language en-US). Correct to US English.
- Markdown linting was marked "local only; no CI", but CI (validate-task)
  runs markdownlint. Correct the claim.
- Document the CI spell-check scope (README.md + HISTORY.md), matching
  ptr727/ProjectTemplate#302, #303.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants