Use the backslash hard break in the Docker Hub overview - #557
Conversation
`Docker/README.md` ended the license line with two trailing spaces to force the break before the badge. The fleet rule is a trailing backslash, and the reason is practical rather than stylistic: two trailing spaces are invisible in a diff and in an editor, and any tool that trims trailing whitespace silently joins the two lines. The only occurrence in the repo's own Markdown; the carried skills tree is excluded from the sweep as hub content. Raised by Qodo on the promotion pull request. Landing it here as well as there so `develop` and `main` stay identical through the promotion rather than leaving `develop` one line behind, which is the main-only drift this repo's own branching rule exists to prevent.
|
Warning Review limit reachedNext included review available in 3 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
PR Summary by QodoUse a durable Markdown hard break in the Docker Hub overview
AI Description
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #557 +/- ##
========================================
Coverage 57.01% 57.01%
========================================
Files 15 15
Lines 1375 1375
Branches 108 108
========================================
Hits 784 784
Misses 573 573
Partials 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, correct Markdown hard-break substitution with no behavioral risk beyond formatting and it aligns with the stated fleet rule.
Pull request overview
Updates the Docker Hub overview Markdown to use the fleet-standard backslash hard line break instead of two trailing spaces, making the forced line break robust to whitespace trimming and more visible in diffs/editors.
Changes:
- Replace the trailing-two-spaces hard break after the license line with a trailing backslash hard break in
Docker/README.md.
File summaries
| File | Description |
|---|---|
| Docker/README.md | Switches the license line’s hard break from trailing spaces to a trailing backslash to prevent accidental whitespace-trim breakage. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
One line.
Docker/README.mdended the license line with two trailing spaces to force the break before the badge; the fleet rule is a trailing backslash.The reason is practical rather than stylistic: two trailing spaces are invisible in a diff and in an editor, and any tool that trims trailing whitespace silently joins the two lines into one. The backslash survives that.
Swept the repo's own Markdown, this was the only occurrence. The carried
.github/skills/tree is excluded as hub content.Why this is a separate PR
Qodo raised it on the promotion PR (#556), so the fix already exists there. Landing the identical change on
developtoo, so the two branches stay content-identical through the promotion.The alternative was to fix it only on
mainvia the promotion and mirror it back afterwards. That is the main-only drift this repo's branching rule exists to prevent, and the promotion PR's own claim is that its tree is byte-identical todevelop, which a one-sided fix would falsify. Cheaper to keep them converged than to owe a back-merge.