Match the file on a spelled-out zero and a size unit - #88
Merged
Conversation
"measured 0 shared inodes" was the only numeral where this file spells the count out, and "~670 M" the only bare M against five uses of MB. The size figure is the host's and was carried in backticks, which presented it as a verbatim quotation and made the unit awkward to correct. It reads as a paraphrase now, "its estimate of ~670 MB for ten releases", which is the same quantity and does not claim to be their exact wording. Both found by Copilot review on #87. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates TODO.md prose to align with existing style conventions established in that file, based on review findings from #87 (the develop → main promotion). The changes are documentation-only and aim to make numeric phrasing and size units consistent with surrounding entries without misrepresenting quoted host output.
Changes:
- Replaces
0with spelled-outzeroin “measured zero shared inodes…” to match the file’s established “zero …” phrasing. - Replaces
~670 Mwith~670 MBand rephrases it as a paraphrase (“its estimate of …”) rather than an inline verbatim quote, keeping the unit consistent with other size mentions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two consistency findings from the review on #87, the promotion. Both measured against the file rather than taken on assertion.
zero shared,zero ofmeasured 0 shared inodes11.4 MB,18 MB,584 MB,585 MB×2~670 MOne judgement worth stating
The size figure is the host's, and I had it in backticks, which presents it as a verbatim quotation and makes the unit awkward to correct — changing a unit inside a quotation misrepresents what someone else wrote.
It now reads as a paraphrase, its estimate of ~670 MB for ten releases, which is the same quantity and does not claim to be their exact words. That resolves the inconsistency without editing a quote.