Drop the deploy root from the environment variables table - #24
Merged
Conversation
The table listed a name no environment carries and no workflow reads, which left the operator-facing list disagreeing with the manifest about whether it should exist. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the operator-facing “Secrets and variables, per environment” documentation to remove DEPLOY_ROOT from the GitHub Environment variables table, aligning the table with the current deployment workflow and manifest behavior.
Changes:
- Removes
DEPLOY_ROOTfrom the GitHub Environment variables list, leavingHUGO_BASEURLas the only variable in that row. - Updates the explanatory paragraph to reflect that the deploy root is not an environment variable and clarifies the difference vs the local
DEPLOY_ROOTinsecrets/<environment>.env. - Adds an explicit rationale for why
DEPLOY_ROOTis intentionally absent from the GitHub Environment table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found on the promotion review.
The operator-facing table listed
DEPLOY_ROOTas a GitHub Environment variable while the manifest had just stopped declaring it, so the two disagreed about whether it should exist. No environment carries it and no workflow reads it, because the rsync destination is anchored at the deploy key's confinement root and the workflow names an environment rather than a host path.The table now says why it is absent, and distinguishes it from the local
DEPLOY_ROOTinsecrets/<environment>.env, which is a different value and still read. That distinction is the reason the stale row was easy to miss: a repo-wide grep for the name returns eleven hits and ten of them are correct.This is the fourth finding in this session of prose surviving the behaviour it described, all of them the sweep this repo has a rule for.
🤖 Generated with Claude Code