Skip to content

Point the hub debt at the issue carrying the proposed wording - #18

Merged
ptr727 merged 4 commits into
developfrom
feature/link-hub-spec-issue
Aug 4, 2026
Merged

Point the hub debt at the issue carrying the proposed wording#18
ptr727 merged 4 commits into
developfrom
feature/link-hub-spec-issue

Conversation

@ptr727

@ptr727 ptr727 commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Why

The hub debt recorded in TODO.md pointed at the intake thread, which asks six questions and now also holds an answer plus a correction superseding its own framing. A reader has to reconstruct which parts stand before they can act.

The change itself is now ProjectTemplate#558, carrying proposed wording for both additions: a deploy-to-host row in Output Seam by Destination, and one D4 guarantee that a deploy is verified against the running host by release id rather than by transport success.

TODO.md now points at both, and says which holds what.

Note

No release dispatch accompanies this. Per the release model a release marks a functional change rather than mechanical churn, and this is a backlog pointer.

🤖 Generated with Claude Code

The intake thread holds the questions and their answers, and the change
itself needs an issue that can be worked without reconstructing which
framing stands.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 4, 2026 21:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the hub-tracking note in TODO.md so it points readers to the specific hub issue that contains the proposed spec wording, while keeping the intake/measured-answers thread referenced for context. This makes it clearer where to read or act next when addressing the publishing-type spec debt.

Changes:

  • Reworded the “Owed to the hub” entry to reference ProjectTemplate#558 as the source of proposed spec wording.
  • Added a new link reference for hub-spec-issue (ProjectTemplate#558) alongside the existing hub-issue link.

Comment thread TODO.md Outdated
The reference sat beside a spelled-out one in the same sentence, so the
bare form read as a local issue number.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings August 4, 2026 21:56
@ptr727
ptr727 requested a lite review from Copilot and removed request for Copilot August 4, 2026 21:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

The review loop was hand-rolled, which re-discovered two failures the hub
script exists to prevent: findings suppressed into a review body reach no
thread, and a request nothing picks up is indistinguishable from a slow
reviewer.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings August 4, 2026 21:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

TODO.md:102

  • This bullet says “The two traps below…”, but there are now three consecutive “trap” bullets immediately below it (the new inert-review-request trap plus the two existing ones). This makes the note internally inconsistent and harder to follow.
- **The hub authors `scripts/pr_review.py`, and hand-rolling the review loop re-discovers its bugs.** One `status` call reports rounds, head coverage, unresolved threads, suppressed findings across every round, and whether a request was ever picked up. `wait` runs the backoff in-process, so a review wait costs one turn rather than one per poll. It is read-only by design and the mutations stay explicit, so fetch and run it rather than reimplementing it. The two traps below are both documented in its README as the reason it exists.

A count of the bullets that follow it is wrong as soon as one is added.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings August 4, 2026 22:01
@ptr727

ptr727 commented Aug 4, 2026

Copy link
Copy Markdown
Owner Author

Fixed in 994fa64.

Valid, and it was mine to cause: I wrote "The two traps below" and then added a third bullet in the same edit.

Removed the count rather than correcting it, since a cross-reference that counts the bullets following it is wrong again the next time one is added. The sentence now names the README as the source without asserting how many follow.

Raised as a suppressed comment, which reaches no thread. Worth noting this round was the first run through the hub's scripts/pr_review.py, which surfaced it in the digest; the hand-rolled loop I had been using would have reported this pull request clean.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@ptr727
ptr727 merged commit 36f5883 into develop Aug 4, 2026
5 checks passed
@ptr727
ptr727 deleted the feature/link-hub-spec-issue branch August 4, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants