Restore JIT warmup calibration default#245
Open
msimacek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyperf has the capability to do automatic warmup calibration for the interpreters that have a JIT. However, the CLI would set the default value of the
--warmupoption to 1, making it impossible to to use the warmup calibration from the CLI because you can't pass None to an int option.The
warmupargument used to have defaultNone, but it was removed in #155 and then reintroduced again in #194 with default1. This PR restores it back toNone. This shouldn't change anything for CPython, since theNonegets converted to1for interpreters without a JIT.