Add ability to register hook from code#236
Merged
Merged
Conversation
Contributor
Author
|
@vstinner Could you please take a look? |
vstinner
reviewed
Mar 20, 2026
| (``list``) which must be modified in place and *args* is the :attr:`args` | ||
| attribute of the runner. | ||
|
|
||
| *hooks* is a list of custom hooks. Each hook should implement ``HookBase`` and |
Member
There was a problem hiding this comment.
Would it be possible to document HookBase so you can refer to it in the doc?
Contributor
Author
There was a problem hiding this comment.
Yes, will do.
Contributor
Author
There was a problem hiding this comment.
Added, but I not very good in writing a documentation.
It is ready to review. Could you please take a look?
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
reviewed
Mar 21, 2026
Co-authored-by: Victor Stinner <vstinner@python.org>
Member
|
Merged, thanks for your contribution. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #235