Complete 3.11 Support #3230

Activity

1. cooperlees

   added

   T: enhancementNew feature or requestNew feature or request

   help wantedExtra attention is neededExtra attention is needed

   C: packagingInstallation and packaging of BlackInstallation and packaging of Black

   C: maintenanceRelated to project maintenance, e.g. CI, testing, policy changes, releasesRelated to project maintenance, e.g. CI, testing, policy changes, releases

   on Aug 18, 2022
2. cooperlees

   self-assigned this

   on Aug 18, 2022
3. cooperlees

   added this to the Release 22.8.0 milestone on Aug 18, 2022
4. ichard26

   self-assigned this

   on Aug 18, 2022
5. ichard26 commented on Aug 18, 2022

   

   ichard26

   on Aug 18, 2022

   Last edited by ichard26

   Collaborator

   More actions

   Regarding aiohttp there's two main problems that make testing 3.11 a bit of a pain:

   • aiohttp's AioHTTPTestCase class seems to be completely broken on 3.11 (here's an example pytest run showing it blow up)
     • Tests with Python 3.11.0b1: RuntimeError: no running event loop / There is no current event loop in thread 'MainThread' aio-libs/aiohttp#6757
   • aiohttp is still uninstallable on 3.11 as their Cython sources have not been regenerated with a new enough Cython that supports 3.11
     • We'll have to set the AIOHTTP_NO_EXTENSIONS environment variable to 1 to skip Cython entirely so aiohttp can be installed (from a sdist, ugh)

   ---

   Regarding mypyc, mypyc already supports 3.11 AFAIK. The problem is on our end. Linux is unsupported since I'm still using this really old manylinux image (that doesn't come with 3.11) to work around the weird linker error.

   black/pyproject.toml

   Lines 64 to 65 in 4ebf14d

   	# Newer images break the builds, not sure why. We'll need to investigate more later.
   	manylinux-x86_64-image = "quay.io/pypa/manylinux2014_x86_64:2021-11-20-f410d11"

   macOS/Windows are raising new type errors (about tomllib out of all things)

     + python -m pip wheel 'D:\a\black-mypyc-wheels\black-mypyc-wheels' '--wheel-dir=C:\Users\runneradmin\AppData\Local\Temp\cibw-run-swrchwj1\cp311-win_amd64\built_wheel' --no-deps -v
     Processing d:\a\black-mypyc-wheels\black-mypyc-wheels
       Preparing metadata (pyproject.toml): started
       Running command Preparing metadata (pyproject.toml)
       Parsed and typechecked in 14.773s
       Compiled to C in 0.000s
       src\black\files.py:29:9: error: Name "tomllib" already defined (by an import)
   

   https://github.com/ichard26/black-mypyc-wheels/runs/7842350331?check_suite_focus=true#step:5:3585

   macOS/Windows should be an easy fix assuming the one type error is all the new errors under 3.11 :)
6. cooperlees

   added a commit that references this issue on Aug 20, 2022

   Add passing 3.11 CI by exempting blackd tests

   ...

   2d27f76
7. JelleZijlstra

   added a commit that references this issue on Aug 23, 2022

   Add passing 3.11 CI by exempting blackd tests (#3234)

   ...

   59acf8a
8. ichard26

   modified the milestones: Release 22.8.0, Release 22.9.0 on Aug 31, 2022
9. hugovk

   added a commit that references this issue on Sep 3, 2022

   Add passing 3.11 CI by exempting blackd tests (psf#3234)

   ...

   8fa87bd
10. dwanderson-intel

    added a commit that references this issue on Oct 6, 2022

    Bump from upstream (#3)

    ...

    81d333f
11. dwanderson-intel

    added a commit that references this issue on Oct 27, 2022

    Upstream force (#8)

    ...

    e5a4a0f
12. kjyv commented on Dec 16, 2022

    

    kjyv

    on Dec 16, 2022

    Last edited by kjyv

    More actions

    I looks like aiohttp 3.8.3 installs fine with Python 3.11 (just tested it). See also aio-libs/aiohttp#6600

    👍React with 👍1Reacted by Cooper Lees

    👀React with 👀1Reacted by Cooper Lees
13. cooperlees commented on Dec 16, 2022

    

    cooperlees

    on Dec 16, 2022

    CollaboratorAuthor

    More actions

    O cool - Thanks for the update - I'll see what hacks I can undo!
14. cooperlees

    closed this as completedin #3446on Dec 17, 2022