Skip to content

groups table structure #23

Open
Open

Description

@Ser5

I read here
http://gatekeeper-auth.readthedocs.org/en/latest/groups/#creating-a-group
that "One thing to note, the group name must be unique".
But groups.name field doesn't have UNIQUE index. I think it should. Currently I can call Gatekeeper::createGroup() with same name multiple times and no errors occur. Additional groups haven't been created, though. Looks like Gatekeeper silently ignores such cases.

And description field is defined as varchar(20). Kind of we cannot put very informative description here =) I think varchar(255) or text would be more useful.

Activity

  1. enygma commented on Jul 18, 2015

    @enygma
    Member

    Not sure what you're seeing over there but in my database the groups.name has a unique key on it.
    And yes, the description probably needs to be expanded...I think 255 should be enough.

  2. Ser5 commented on Jul 18, 2015

    @Ser5
    ContributorAuthor

    My fault: groups.name definitely has an unique key.

  3. enygma commented on Jul 18, 2015

    @enygma
    Member

    Ah, no worries...easy thing to miss. I think expanding that description column should probably be a new migration too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions