You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I read here http://gatekeeper-auth.readthedocs.org/en/latest/groups/#creating-a-group
that "One thing to note, the group name must be unique".
But groups.name field doesn't have UNIQUE index. I think it should. Currently I can call Gatekeeper::createGroup() with same name multiple times and no errors occur. Additional groups haven't been created, though. Looks like Gatekeeper silently ignores such cases.
And description field is defined as varchar(20). Kind of we cannot put very informative description here =) I think varchar(255) or text would be more useful.
Not sure what you're seeing over there but in my database the groups.name has a unique key on it.
And yes, the description probably needs to be expanded...I think 255 should be enough.
Activity
enygma commentedon Jul 18, 2015
Not sure what you're seeing over there but in my database the
groups.namehas a unique key on it.And yes, the description probably needs to be expanded...I think 255 should be enough.
Ser5 commentedon Jul 18, 2015
My fault:
groups.namedefinitely has an unique key.enygma commentedon Jul 18, 2015
Ah, no worries...easy thing to miss. I think expanding that description column should probably be a new migration too.