Refactor class thermal error handling - #794
Merged
Merged
Conversation
This was referenced Mar 8, 2026
Include any read errors when parsing /sys/class/thermal/thermal_zone data. This avoids premature error returns if there are platform specific problems like `temp` being unreadable, even tho it's a required file. Related to: prometheus/node_exporter#2980 Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/thermal_errors
branch
from
March 8, 2026 10:55
96f2c92 to
6c4d375
Compare
sysadmind
approved these changes
Mar 13, 2026
sysadmind
left a comment
sysadmind
left a comment
There was a problem hiding this comment.
I don't really know how this is used, but the code itself seems fine.
I would note that this seems like a heavily imported package, and I think this constitutes a breaking change, so this feels like it warrants a big scary changelog message.
https://pkg.go.dev/github.com/prometheus/procfs?tab=importedby
Member
Author
|
Yes, we make regular breaking changes to this library to fix behavior problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include any read errors when parsing /sys/class/thermal/thermal_zone data. This avoids premature error returns if there are platform specific problems like
tempbeing unreadable, even tho it's a required file.Related to: prometheus/node_exporter#2980