Remove boilerplate code by adopting exporter-toolkit's bootstrap.Runner() - #3660
Merged
ArthurSens merged 1 commit intoAug 27, 2026
Merged
Conversation
nicolastakashi
force-pushed
the
embeddable-config-foundation
branch
from
May 19, 2026 15:09
5ca7d6e to
f2787ac
Compare
This was referenced May 19, 2026
SuperQ
reviewed
May 20, 2026
nicolastakashi
force-pushed
the
embeddable-config-foundation
branch
from
May 21, 2026 13:34
1eb3d4d to
7e1df8c
Compare
nicolastakashi
force-pushed
the
embeddable-config-foundation
branch
from
July 1, 2026 15:04
72785de to
f1b2dcc
Compare
nicolastakashi
marked this pull request as ready for review
July 1, 2026 15:05
ArthurSens
approved these changes
Aug 20, 2026
ArthurSens
left a comment
ArthurSens
left a comment
Member
There was a problem hiding this comment.
Just needs a rebase, I believe :)
nicolastakashi
force-pushed
the
embeddable-config-foundation
branch
from
August 25, 2026 18:17
f1b2dcc to
921631f
Compare
Contributor
Author
|
@ArthurSens PTAL 🙏🏽 |
ArthurSens
requested changes
Aug 25, 2026
ArthurSens
left a comment
ArthurSens
left a comment
Member
There was a problem hiding this comment.
I just realized that moving to a new server mux will disable /debug/pprof since we're just importing the global _ "net/http/pprof".
Could we add it as a additional route to the bootstrap server mux?
Member
|
The commit history and PR title also look a bit weird, so we might need to make some adjustments there 😬 |
nicolastakashi
force-pushed
the
embeddable-config-foundation
branch
2 times, most recently
from
August 26, 2026 18:43
b117f4b to
ac17919
Compare
Refactor node_exporter's entrypoint to build its configuration and run via the exporter-toolkit bootstrap runner, as groundwork for making node_exporter easier to embed outside the standalone binary. Register /debug/pprof/ on the bootstrap mux via Bootstrap.Handle so it stays reachable now that the bootstrap runner uses its own mux instead of http.DefaultServeMux. Signed-off-by: Nicolas Takashi <nicolas.tcs@hotmail.com>
nicolastakashi
force-pushed
the
embeddable-config-foundation
branch
from
August 27, 2026 05:32
ac17919 to
1dece8a
Compare
ArthurSens
changed the title
Member
|
Nice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This starts a small, incremental refactor to make
node_exportereasier to embed outside the standalone binary.The broader goal is to support ongoing work to make Prometheus exporters embeddable inside the Prometheus OpenTelemetry Collector distribution as native receivers, without requiring each exporter to be rewritten as an OpenTelemetry component.
As a first step, this PR introduces a standalone
configpackage that:ConfigtypeThis does not make
node_exporterfully embeddable yet. It is intended as groundwork for follow-up changes that will extract reusable runtime construction from the CLI layer and gradually reduce process-global configuration wiring.Why
Today, top-level exporter configuration is constructed directly in the binary entrypoint. Moving that configuration shape into a reusable package gives downstream callers and future runtime code a shared place for:
That is a useful first step toward separating: