Refactor typed metric descriptors - #3448
Merged
Merged
Conversation
SuperQ
commented
Oct 23, 2025
SuperQ
commented
Member
- Remove second implementation of typedDesc.
- Refactor pcidevice Desc vars to be typedDesc.
* Remove second implementation of typedDesc. * Refactor pcidevice Desc vars to be typedDesc. Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
marked this pull request as ready for review
October 23, 2025 10:45
Member
Author
Member
Author
|
👓 @Tiger1218 |
sysadmind
approved these changes
Oct 24, 2025
ShashwatHiregoudar
pushed a commit
to ShashwatHiregoudar/node_exporter
that referenced
this pull request
Mar 3, 2026
* Remove second implementation of typedDesc. * Refactor pcidevice Desc vars to be typedDesc. Signed-off-by: Ben Kochie <superq@gmail.com> Signed-off-by: Shashwat Hiregoudar <shashwathiregoudar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.