docs: Remove tcpstat exporter warning - #3305
Open
fionera wants to merge 2 commits into
Open
Conversation
SuperQ
requested changes
Oct 22, 2025
SuperQ
left a comment
SuperQ
left a comment
Member
There was a problem hiding this comment.
This needs a DCO sign-off. You can use git commit -s --amend to add it.
fionera
force-pushed
the
patch-1
branch
2 times, most recently
from
November 10, 2025 10:07
89eb481 to
24db8fa
Compare
The warning is not true since prometheus#2322. Signed-off-by: Tim Windelschmidt <fionera@fionera.de>
SuperQ
reviewed
Jul 10, 2026
| swap | Expose swap information from `/proc/swaps`. | Linux | ||
| systemd | Exposes service and system status from [systemd](http://www.freedesktop.org/wiki/Software/systemd/). | Linux | ||
| tcpstat | Exposes TCP connection status information from `/proc/net/tcp` and `/proc/net/tcp6`. (Warning: the current version has potential performance issues in high load situations.) | Linux | ||
| tcpstat | Exposes TCP connection status information from `/proc/net/tcp` and `/proc/net/tcp6`. | Linux |
Member
There was a problem hiding this comment.
How about:
Suggested change
| tcpstat | Exposes TCP connection status information from `/proc/net/tcp` and `/proc/net/tcp6`. | Linux | |
| tcpstat | Exposes TCP connection status information from netlink. Warning: hosts with high connection counts may increase scrape times. | Linux |
Member
There was a problem hiding this comment.
At a minimum we need to update the docs to mention netlink.
Suggested change
| tcpstat | Exposes TCP connection status information from `/proc/net/tcp` and `/proc/net/tcp6`. | Linux | |
| tcpstat | Exposes TCP connection status information from netlink`. | Linux |
Member
|
While it's much cheaper with netlink, on high load machines the improved implementation still takes 1-2 seconds. This is very long considering the p50 for node_exporter on a fleet of reasonably big machines (i.e m7a.24xlarge) is only 50ms. |
Contributor
Author
|
But thats with millions of connections, which is a size where none of the normal behavior is expected to hold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning is not true since #2322. I would also propose to enable it by default