Skip to content

build(deps): migrating kingpin.v2 to github.com/alecthomas/kingpin/v2 - #2619

Closed
arukiidou wants to merge 1 commit into
prometheus:masterfrom
arukiidou:fix/kingpin-migrate
Closed

build(deps): migrating kingpin.v2 to github.com/alecthomas/kingpin/v2#2619
arukiidou wants to merge 1 commit into
prometheus:masterfrom
arukiidou:fix/kingpin-migrate

Conversation

@arukiidou

@arukiidou arukiidou commented Mar 4, 2023

Copy link
Copy Markdown

note

Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
@SuperQ

SuperQ commented Mar 4, 2023

Copy link
Copy Markdown
Member

We need to update the exporter-toolkit first.

@arukiidou

Copy link
Copy Markdown
Author

Wow, somehow this does not work in 32bit.🤔

@SuperQ

SuperQ commented Mar 7, 2023

Copy link
Copy Markdown
Member

I figured out the 32-bit problem, the new kingpin was using an old version of a time duration parsing library.

This is done in #2622

@SuperQ SuperQ closed this Mar 7, 2023
@arukiidou

Copy link
Copy Markdown
Author

32 ビットの問題を突き止めました。新しいキングピンは、古いバージョンの持続時間解析ライブラリを使用していました。

これは#2622で行われます

Cool! thanks for your quick progress.

@arukiidou
arukiidou deleted the fix/kingpin-migrate branch May 10, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants