Update procfs vendor - #1248
Merged
Merged
Conversation
Contributor
Author
|
So it actually required significantly more changes that I realized at first. This should hopefully pass the tests now. The name of the commit is only half relevant now :/ |
Member
|
Thanks, this was on my todo list! |
SuperQ
self-requested a review
February 3, 2019 11:01
Member
|
Looks good. We should add a CHANGELOG entry for this. ### **Breaking changes**
The cpufreq metrics now separate the `cpufreq` and `scaling` data based on what the driver provides. #1248
...
* [CHANGE] Add separate cpufreq and scaling metrics #1248 |
Signed-off-by: Mark Knapp <mknapp@hudson-trading.com>
Contributor
Author
|
Sounds good, is the go-kstat stuff ok? |
Member
|
Yes, the go-kstat fix is fine. Not sure why the vendor check didn't fail when that PR was submitted. |
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
Signed-off-by: Mark Knapp <mknapp@hudson-trading.com>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
Signed-off-by: Mark Knapp <mknapp@hudson-trading.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm updating the vendor code so I can address the changes I proposed in #994. I did it separately because it also introduced an issue with cpu_linux that needed to be addressed and I thought it might be best not to have all of it in 1 commit.
I'm not entirely sure if this is right, I ran:
go get github.com/prometheus/procfsGO111MODULE=on go mod tidyGO111MODULE=on go mod vendorand it pulled in go-kstat stuff too, is there a reason this wasn't included before?
Signed-off-by: Mark Knapp mknapp@hudson-trading.com