allow textfile to be overwritten on windows#650
Merged
csmarchbanks merged 4 commits intoprometheus:masterfrom May 11, 2021
Merged
allow textfile to be overwritten on windows#650csmarchbanks merged 4 commits intoprometheus:masterfrom
csmarchbanks merged 4 commits intoprometheus:masterfrom
Conversation
Signed-off-by: Sander Van de Moortel <sander.vandemoortel@gmail.com>
bluppfisk
force-pushed
the
fix_rename_windows
branch
from
348eee8 to
0be4d06
Compare
Contributor
Author
|
Python 3.4 test fails because the typing package (used in Tox) was added in v3.5. Unsure how to fix |
Member
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
Thanks, one comment, but I don't feel too strongly about it.
The test failure appears to be due to a bad release of attrs: https://www.attrs.org/en/stable/changelog.html, but that release has been yanked so i am not sure why it is still being chosen in the tests. I will dig in a bit further when I have a moment.
Signed-off-by: Sander Van de Moortel <sander.vandemoortel@gmail.com>
bluppfisk
force-pushed
the
fix_rename_windows
branch
from
2f1bc8d to
1089530
Compare
Member
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
Thanks for the update! Another comment, but otherwise this looks good to me. I will likely merge without the 3.4 test passing as the failure is clearly unrelated.
Signed-off-by: Sander Van de Moortel <sander.vandemoortel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prospective fix for issue #649
For POSIX installations, nothing changes. For Windows installations, if python>=3.3 is detected, it will use
os.replace, else it will do a double operation ofos.removefollowed byos.rename, either of which may fail and result in (temporarily or permanently) broken metrics.This can be refined to catch such errors.