Catch name clashes in the OM parser.#577
Merged
brian-brazil merged 4 commits intomasterfrom Nov 13, 2020
Merged
Conversation
brian-brazil
force-pushed
the
name-clash
branch
2 times, most recently
from
17fb31c to
2e26e2f
Compare
Contributor
Author
|
@SuperQ Updated as per the meeting just there. |
Member
|
Looks like this needs a rebase. |
Make sure we're catching all the cases in the client too. This means you can't have a foo counter and a foo_created gauge. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
This is so the average can be calculated. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
brian-brazil
force-pushed
the
name-clash
branch
from
094f18f to
377f826
Compare
Contributor
Author
|
Rebased. |
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
brian-brazil
force-pushed
the
name-clash
branch
from
377f826 to
fdf7124
Compare
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure we're catching all the cases in the client too.
This means you can't have a foo counter and a foo_created gauge.
@SuperQ Per the most recent discussions.