Bugfix urlparse in python >= 3.7.6#497
Merged
brian-brazil merged 2 commits intoprometheus:masterfrom Dec 23, 2019
Merged
Conversation
Signed-off-by: George Mossessian <gmossessian@gmail.com>
bfa589c to
0c5b611
Compare
prometheus_client/exposition.py
Outdated
|
|
||
| PYTHON26_OR_OLDER = sys.version_info < (2, 7) | ||
|
|
||
| # Due to https://bugs.python.org/issue27657: |
Contributor
There was a problem hiding this comment.
I'd put this comment down where you use it
Signed-off-by: George Mossessian <gmossessian@gmail.com>
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3.7.6, a patch has been released that changes the behavior of
urllib.parse.urlparse. This causes an error when pushing to a gateway without a scheme specified in the url string, but with a port.Patch details here: https://bugs.python.org/issue27657
Proof of failure on my local branch: