multiprocess: don't crash on missing gauge_live/sum files#424
Merged
brian-brazil merged 1 commit intoprometheus:masterfrom Jun 18, 2019
Merged
Conversation
xavfernandez
force-pushed
the
xfernandez/ignore_missing_gauge_livexxx
branch
4 times, most recently
from
63b8390 to
4327668
Compare
Contributor
|
Thanks, there's a test failure. |
Contributor
Author
Yes, it is apparently failing in master too: https://travis-ci.org/prometheus/client_python/builds/542696662 |
Fixes prometheus#425 Signed-off-by: Xavier Fernandez <xavier.fernandez@polyconseil.fr>
xavfernandez
force-pushed
the
xfernandez/ignore_missing_gauge_livexxx
branch
from
4327668 to
0514a83
Compare
Contributor
Author
|
With #428 merged, all tests now pass. |
Contributor
|
Thanks! |
Contributor
Author
No problem, thanks for your work :) |
Contributor
|
I'll have a better idea this evening after the OpenMetrics meeting. |
Contributor
Author
How did it go ? 😀 |
Contributor
|
We didn't discuss the relevant point, so I've put a release on my todo list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #425