Avoid re-entrant calls to GC collector's callback#343
Merged
brian-brazil merged 1 commit intoprometheus:masterfrom Nov 16, 2018
Merged
Avoid re-entrant calls to GC collector's callback#343brian-brazil merged 1 commit intoprometheus:masterfrom
brian-brazil merged 1 commit intoprometheus:masterfrom
Conversation
It looks like the Python GC engine can call the GC callback while it's still being called (likely if the callback does significant enough work), which may, if you're unlucky enough, lead into a stack overflow Python is unable to recover from. This patch should fix it, though no empirical tests have been made. Signed-off-by: Aarni Koskela <akx@iki.fi>
Contributor
|
We should probably also try to avoid allocating memory in this function, such as by caching the children. That'll reduce the amount of data we lose due to this. |
Contributor
Author
|
Is that worth the added complexity? Either way, maybe another issue should be made for that, and this merged so people don't have their Pythons fatally crashing... |
Contributor
It'd avoid losing data on all bar the first GC, and be a little faster too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the Python GC engine can call the GC callback
while it's still being called (likely if the callback does significant
enough work), which may, if you're unlucky enough, lead into a stack
overflow Python is unable to recover from.
This patch should fix it, though no empirical tests have been made.
Refs this issue comment: #322 (comment)