Fix Windows path normalization in target plans

[ayskobtw-lil]

Summary

• Normalize target manifest file lists to use POSIX / separators on Windows for Roku and static web outputs
• Preserve POSIX-style fake/project paths in JSR, VS Code, and Safari target plans instead of converting /repo/... to \repo\... on Windows
• Keep real Windows paths supported by only using POSIX joins when the provided base path is POSIX-style

Why

Running the target adapter tests on Windows exposed cross-platform path handling bugs: generated manifests and mocked command cwd values contained backslashes even where the package contract/tests expect portable POSIX-style paths.

Validation

• pnpm exec vitest run packages/targets/tv-roku/src/index.test.ts packages/targets/web-static/src/index.test.ts packages/targets/pkg-jsr/src/index.test.ts packages/targets/plugin-vscode/src/index.test.ts packages/targets/browser-safari/src/index.test.ts -> 30 passed
• pnpm --filter @profullstack/sh1pt-target-tv-roku typecheck
• pnpm --filter @profullstack/sh1pt-target-web-static typecheck
• pnpm --filter @profullstack/sh1pt-target-pkg-jsr typecheck
• pnpm --filter @profullstack/sh1pt-target-plugin-vscode typecheck
• pnpm --filter @profullstack/sh1pt-target-browser-safari typecheck

For the ugig bug-fix bounty: this PR fixes Windows-only path separator failures found while running the test suite locally.

[ayskobtw-lil]

Opened the matching bug report as #444 for the ugig bug-fix trail. This PR fixes that Windows path normalization issue.

[greptile-apps]

Greptile Summary

This PR fixes cross-platform path separator bugs exposed when running the target adapter test suite on Windows. Two distinct strategies are applied: file listing paths in tv-roku and web-static are normalized post-relative() with .split(sep).join('/'), while path-building helpers in pkg-jsr, plugin-vscode, and browser-safari gain an isWindowsPath heuristic that routes to posix.join/posix.resolve for POSIX-style fake paths and native join/resolve for real Windows paths.

• tv-roku / web-static: listFiles now converts native separators in relative paths to / before they land in manifests, fixing backslash entries in the files array on Windows.
• pkg-jsr / plugin-vscode / browser-safari: New isWindowsPath + joinLike/resolveLike helpers preserve POSIX-style project/out paths used in tests while keeping real Windows paths correctly handled; all previously-flagged native-join call sites (planPath, packageArtifact, archivePath, etc.) are addressed.

Confidence Score: 5/5

Safe to merge — changes are well-scoped to path normalization helpers with no side effects on real build/ship logic.

The two fix strategies (sep-split normalization for file lists; isWindowsPath-gated posix.join for path builders) are both correct. All previously-flagged native-join call sites from earlier review rounds have been addressed. The remaining native-join calls in browser-safari's real build path are macOS-only filesystem operations where native separators are appropriate. No logic changes outside of path construction.

No files require special attention.

Important Files Changed

Filename	Overview
packages/targets/tv-roku/src/index.ts	Normalizes file list paths using .split(sep).join('/') — correct and minimal change; outer join/resolve calls for filesystem I/O correctly retain native paths.
packages/targets/web-static/src/index.ts	Same sep-split normalization as tv-roku for the file manifest list; all other paths (artifact, sourceDir) stay native for correct filesystem I/O.
packages/targets/pkg-jsr/src/index.ts	Adds isWindowsPath heuristic and conditional posix.join for packagePath; only the cwd passed to external commands is affected, and POSIX-style fake paths are preserved correctly in tests.
packages/targets/plugin-vscode/src/index.ts	Adds isWindowsPath, joinLike, and fixes both packageDir, packageArtifact, and the planPath inline — all previously-flagged native-join call sites are addressed.
packages/targets/browser-safari/src/index.ts	Adds isWindowsPath, joinLike, resolveLike; converts all path-building in buildPlan and planPath; the remaining native join calls in the real build() path are for macOS-only filesystem operations where native separators are correct.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Path joining needed] --> B{Which file?}
    B -->|tv-roku / web-static| C[Use native join for I/O traversal]
    C --> D["relative(root, path)"]
    D --> E[".split(sep).join('/')"]
    E --> F[POSIX-normalized string in manifest]

    B -->|pkg-jsr / plugin-vscode / browser-safari| G["isWindowsPath(base)?"]
    G -->|"includes('\\') OR /^[A-Za-z]:\\//"| H[Windows path detected]
    G -->|neither condition| I[POSIX path detected]
    H --> J["native join / resolve"]
    I --> K["posix.join / posix.resolve"]
    J --> L[Correct Windows path]
    K --> M[POSIX path preserved]

Loading

_{Reviews (4): Last reviewed commit: "Address path normalization review" | Re-trigger Greptile}

[ayskobtw-lil]

Fixed the review items in a54d0ea: �rowser-safari now uses the path-preserving helper for the dry-run plan path, plugin-vscode uses it for the dry-run plan file path, and the Windows-path heuristic no longer treats // POSIX paths as Windows. Re-ran the five targeted test files (30 passed) and typechecks for the touched target packages.

[github-actions]

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

[ayskobtw-lil]

Rebased this branch onto current upstream master after the auto-rebase bot could not push to the fork. New head is 3935725.\n\nVerification after rebase:\n- npx --yes pnpm@9.12.0 exec vitest run packages/targets/tv-roku/src/index.test.ts packages/targets/web-static/src/index.test.ts packages/targets/pkg-jsr/src/index.test.ts packages/targets/plugin-vscode/src/index.test.ts packages/targets/browser-safari/src/index.test.ts -> 30 passed\n- typecheck passed for @profullstack/sh1pt-target-tv-roku, @profullstack/sh1pt-target-web-static, @profullstack/sh1pt-target-pkg-jsr, @profullstack/sh1pt-target-plugin-vscode, and @profullstack/sh1pt-target-browser-safari

[github-actions]

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

[ayskobtw-lil]

Rebased again onto current upstream master after the latest auto-rebase bot comment. New head is 5a346f7.\n\nVerification after rebase:\n- npx --yes pnpm@9.12.0 exec vitest run packages/targets/tv-roku/src/index.test.ts packages/targets/web-static/src/index.test.ts packages/targets/pkg-jsr/src/index.test.ts packages/targets/plugin-vscode/src/index.test.ts packages/targets/browser-safari/src/index.test.ts -> 30 passed\n- typecheck passed for @profullstack/sh1pt-target-tv-roku, @profullstack/sh1pt-target-web-static, @profullstack/sh1pt-target-pkg-jsr, @profullstack/sh1pt-target-plugin-vscode, and @profullstack/sh1pt-target-browser-safari